Proposal 134254 to upgrade the NNS dapp (22/11/2024)

Governance NNS Governance
,
1

Happy Friday, ICPeople! Proposal 134254 to upgrade the NNS dapp just went live, please consider voting. :ballot_box:

This week’s proposal is similar to last week’s with a few additional improvements and fixes. Last week’s proposal was adopted but failed quietly, so we are proposing those changes in this proposal as well. See more here.

Upgrade NNS Canister: qoctq-giaaa-aaaaa-aaaea-cai to wasm with hash: d54718853fb1abaf34ca774fd980164579bd4e6d3bcb0a141e799b8c699b97aa

Change Log

Changed

  • Claim unclaimed neurons from the frontend instead of the backend.
  • Update proposal status colors.

Removed

  • Stop storing neuron accounts in the nns-dapp canister.

Fixed

  • Stop trying to get swap commitments from aborted SNSes.
  • Stop making unnecessary calls to SNS-W and SNS root canisters.
  • User gets the wrong identity when connecting different hardware wallets devices in a certain order.
  • Fix candid decoding error of stable memory.
  • Show successfully loaded swap commitments even if some fail to load.

Wasm Verification

To build the wasm module yourself and verify its hash, run the following commands from the root of the nns-dapp repo:

git fetch  # to ensure you have the latest changes.
git checkout "7f408e7a4866183c4408ab599fce8b342a7843fe"
git merge-base --is-ancestor HEAD origin/main && echo "OK" || echo "Commit is not on main branch!"
./scripts/docker-build
sha256sum nns-dapp.wasm.gz

You may also want to verify the canister arguments. In the proposal they are binary, which is not very readable. Docker provides both binary and text formats and you can verify that the text format corresponds to the binary arg_hex field in the proposal.

cat nns-dapp-arg-mainnet.did
didc encode "$(cat nns-dapp-arg-mainnet.did)" | xxd -r -p | sha256sum
1 Like
2

Been a while since I did this.

Screenshot 2024-11-22 191935
Screenshot 2024-11-22 1919351913×952 63.3 KB

Builds fine and as can be seen both the wasm and arguments hash matches the payload.
There are lots of commits to go through and as I skimmed over them two interesting ones caught my eye. One was the addition of the ENABLE_EXPORT_NEURONS_REPORT new feature flag (c6e4e8f) for exporting neurons state snapshots and the one with neuron’s activity state where is great to see that notification for users about decreasing rewards start time is set for 30 days. Enough spoilers, I recommend anyone who is trying to keep up with relevant changes for the NNS to take the time and review them.

1 Like