Proposal 134171 to upgrade the NNS dapp (15/11/2024)

Governance NNS Governance
,
1

Happy Friday, ICPeople! Proposal 134171 to upgrade the NNS dapp just went live, please consider voting. :ballot_box:

This week’s proposal is all about performance improvements and bug fixes.

Upgrade frontend NNS Dapp canister to commit 165b0b4aaefdd075c48932302aba7c1b4bca1d36

Wasm sha256 hash: af33eac1b7d02db29a978020520a414e730c89fde4eecf0d33a8a7b84aff100c (https://github.com/dfinity/nns-dapp/actions/runs/11816928413)

Change Log

Changed

  • Claim unclaimed neurons from the frontend instead of the backend.

Removed

  • Stop storing neuron accounts in the nns-dapp canister.

Fixed

  • Stop trying to get swap commitments from aborted SNSes.
  • Stop making unnecessary calls to SNS-W and SNS root canisters.
  • User gets the wrong identity when connecting different hardware wallets devices in a certain order.

Wasm Verification

To build the wasm module yourself and verify its hash, run the following commands from the root of the nns-dapp repo:

git fetch  # to ensure you have the latest changes.
git checkout "165b0b4aaefdd075c48932302aba7c1b4bca1d36"
git merge-base --is-ancestor HEAD origin/main && echo "OK" || echo "Commit is not on main branch!"
./scripts/docker-build
sha256sum nns-dapp.wasm.gz

You may also want to verify the canister arguments. In the proposal they are binary, which is not very readable. Docker provides both binary and text formats and you can verify that the text format corresponds to the binary arg_hex field in the proposal.

cat nns-dapp-arg-mainnet.did
didc encode "$(cat nns-dapp-arg-mainnet.did)" | xxd -r -p | sha256sum
2 Likes
2

For anyone closely following NNS dapp proposals:

Today (18/11/2024), proposal 134171 was adopted, but the upgrade failed quietly. This was due to an error during deserialization in the post-upgrade hook, which prevented the NNS dapp to upgrade to Wasm hash af33eac1b7d02db29a978020520a414e730c89fde4eecf0d33a8a7b84aff100c. You should expect to see the NNS dapp canister to still show the old Wasm hash 2686b9d9b702a6a23d1378f643f607dcb99e3e928fdc852249fe0375f0c7a4ce.

We plan to submit a new proposal that will include additional changes later this week in accordance with our usual release schedule.

4 Likes