Proposal 133306 to upgrade the NNS dapp (04/10/2024)

[chepreghy]

Hello ICPeople! Proposal 133306 to upgrade the NNS dapp just went live, please consider voting.

This proposal includes improvements to the profile menu adding your main ICP account ID and principal ID to a central place that is easier to find. This proposal also includes moving “Canisters” from the sidebar to the profile menu as it is a feature of the NNS dapp that receives fewer updates.

The sidebar is also getting some improvements, namely an update to the theme switcher that moves to a more prevalent place and can be accessed without signing in.

If this proposal may be familiar for frequent forum visitors, as it contains changes also proposed last Tuesday (24/09/2024). Unfortunately, there was a bug introduced that would freeze the NNS dapp when viewing some SNS proposals. This issue has since been addressed.

Change Log

Added

• Added get_tvl method to nns-dapp canister.
• Display of principal Id and main ICP account Id in the account menu.

Changed

• Changes for cleaning up the stable structure migration.
• Move Canisters button from sidebar to account menu.
• Move GitHub button from account menu to sidebar.
• Reduce calls to sns-governance canister by getting nervous_system_parameters from the aggregator instead.
• Move theme toggle from account menu to sidebar.
• The Markdown UI component was migrated to @dfinity/gix-components.

Removed

• Stop making unnecessary calls to load the SNS proposal every time we load the derived state.

Fixed

• Fixed a bug where a performance counter in init is wiped during state initialization.
• Bug with parsing nervous system parameters from aborted SNSes.

Wasm Verification

To build the wasm module yourself and verify its hash, run the following commands from the root of the nns-dapp repo:

git fetch  # to ensure you have the latest changes.
git checkout "d53c090c258017b634c635f4ba1324501731be40"
git merge-base --is-ancestor HEAD origin/main && echo "OK" || echo "Commit is not on main branch!"
./scripts/docker-build
sha256sum nns-dapp.wasm.gz

You may also want to verify the canister arguments. In the proposal they are binary, which is not very readable. Docker provides both binary and text formats and you can verify that the text format corresponds to the binary arg_hex field in the proposal.

cat nns-dapp-arg-mainnet.did
didc encode "$(cat nns-dapp-arg-mainnet.did)" | xxd -r -p | sha256sum

[ICdex]

@chepreghy after this update when enter canister ,maybe you can try it !!!

[chepreghy]

Hey, thank you for reaching out! We know about the, see this thread for more info:

Is canisters management broken on nns.ic0.app?

Hey @CodingFu, thank you for reaching out! We noticed this issue yesterday and are working on a fix. We plan to submit the NNS proposal on Friday. If it is adopted, and everything goes well, the fix will take effect some time next Monday (14/10/2024). Do you have any other controllers on your canister? In which case, you can use dfx in the meantime to add or remove controllers.

TLDR; if the proposal is adopted, the fix should be released some time on Monday.