Proposal 133098 to upgrade the NNS dapp (24/09/2024)

Governance NNS proposal discussions
,
1

Hello ICPeople! Proposal 133098 to upgrade the NNS dapp just went live, please consider voting. :ballot_box:

This proposal includes improvements to the profile menu adding your main ICP account ID and principal ID to a central place that is easier to find. This proposal also includes moving “Canisters” from the sidebar to the profile menu as it is a feature of the NNS dapp that receives fewer updates.

Profile menu
Profile menu1342Ă—814 52.7 KB

The sidebar is also getting some improvements, namely an update to the theme switcher that moves to a more prevalent place and can be accessed without signing in.

Theme switcher

Wasm sha256 hash: d14ed3984903221eba0f5975e3ee2312adba6975f2b6629347b3dab2249cd4aa (https://github.com/dfinity/nns-dapp/actions/runs/10958553701)

Change Log

Added

  • Added get_tvl method to nns-dapp canister.
  • Display of principal Id and main ICP account Id in the account menu.

Changed

  • Changes for cleaning up the stable structure migration.
  • Move Canisters button from sidebar to account menu.
  • Move GitHub button from account menu to sidebar.
  • Reduce calls to sns-governance canister by getting nervous_system_parameters from the aggregator instead.
  • Move theme toggle from account menu to sidebar.
  • The Markdown UI component was migrated to @dfinity/gix-components.

Removed

  • Stop making unnecessary calls to load the SNS proposal every time we load the derived state.

Fixed

  • Fixed a bug where a performance counter in init is wiped during state initialization.

Wasm Verification

To build the wasm module yourself and verify its hash, run the following commands from the root of the nns-dapp repo:

git fetch  # to ensure you have the latest changes.
git checkout "efdfb9a59651e18d3c33ae7c13e3db1e62d63ed9"
git merge-base --is-ancestor HEAD origin/main && echo "OK" || echo "Commit is not on main branch!"
./scripts/docker-build
sha256sum nns-dapp.wasm.gz

You may also want to verify the canister arguments. In the proposal they are binary, which is not very readable. Docker provides both binary and text formats and you can verify that the text format corresponds to the binary arg_hex field in the proposal.

cat nns-dapp-arg-mainnet.did
didc encode "$(cat nns-dapp-arg-mainnet.did)" | xxd -r -p | sha256sum
7 Likes
2

I can’t enter neuron detail page and proposal page:

1 Like
3

Voting page is not displaying any data for voting on anything that is not ICP proposal and actually causing me to do a total refresh on the main page to fix and it repeats, I can vote on ICP proposals still without issue. This is a big deal, please addresss

4

Unfortunately, there was a bug introduced, so we had to propose a rollback. Could you please try again?