NNS Updates Nov 21, 2023

The NNS Team will be submitting the following upgrade proposals this Tuesday, 2023-11-21. DFINITY plans to vote on these proposals early morning Zurich the next day.

Hot Fix for NNS Governance Incident

Due to an issue with a release on Monday, November 20th, heartbeats ran out of cycles. To fix this, we rolled back to the previously deployed version of Governance.

However, today it was found that there was an additional issue where the Neuron Spawning lock was never released, thereby preventing neurons from spawning. Additionally, one neuron had an unreleased neuron lock.

We were able to verify that this issue did not leave neurons and ledger transactions in an inconsistent state.

We are now releasing a patch to the currently deployed version that releases the locks on spawning and the single neuron affected with a neuron lock.

This change (in post_upgrade) will not be merged back into the main branch, as it does not need to execute more than one time.

The hotfix branch (mentioned in the proposal) will be mirrored as soon as possible to Github for verification.

Proposals to be Submitted


## Proposal to Upgrade the Governance Canister
### Proposer: DFINITY Foundation
### Git Hash: 58944c61835a3c49fcf822997f0953ae1882caab
### New Wasm Hash: 3eadce8399b6bc9450bfb8bb54adefc1e27b2564146684d4c6d41a62c4110b73
### Target canister: rrkah-fqaaa-aaaaa-aaaaq-cai
## Hotfix
An upgrade proposal on Nov 20 caused NNS Governance heartbeats to hit the instruction limit.  After rolling this back, it was discovered that some neurons were not able to finish spawning. The issue in heartbeats created a permanent lock on spawning, and caused one neuron to be locked.  After investigating, all neurons were shown to have correct values, meaning it is safe to rest the Neuron Spawning lock and to unlock the single affected neuron.

This release only patches the currently deployed version of NNS Governance (which was rolled back to late November 20th), and does not contain other changes.

This release is built from branch hotfix-no-rc--nns-2023-11-20, and these changes will not be merged back into the master branch, as they only need to be executed once. 

## Release Notes
$ git log --format="%C(auto) %h %s" 751b2a0cf904934b4afb62b1457f6bf4f0a20275..58944c61835a3c49fcf822997f0953ae1882caab --  ./rs/nns/governance
 58944c6183 Address feedback
 540457a5f9 Unlock spawning neurons and the neuron lock

## Wasm Verification
Verify that the hash of the gzipped WASM matches the proposed hash.
git fetch
git checkout 58944c61835a3c49fcf822997f0953ae1882caab
./gitlab-ci/container/build-ic.sh -c
sha256sum ./artifacts/canisters/governance-canister.wasm.gz
## Current Version
- Current Git Hash: 751b2a0cf904934b4afb62b1457f6bf4f0a20275
- Current Wasm Hash: 371a96090299d73ff243119d127694569f28b7585c23975d8637fd5d5c00b7fc

Hi all, quick update from our side: this proposal has been adopted and the two issues were resolved:

  1. The Neuron Spawning lock was released, so neurons can be spawning again.
  2. The neuron with an unreleased neuron lock got this lock released.
1 Like