NNS Updates 2025-05-30

[msumme]

The NNS Team submitted the following proposals. DFINITY plans to vote on these proposals the following Monday.

• https://dashboard.internetcomputer.org/proposal/136795
• https://dashboard.internetcomputer.org/proposal/136796
• https://dashboard.internetcomputer.org/proposal/136797

Proposals to be Submitted

Cycles-minting

# Upgrade the Cycles-minting Canister to Commit 250daf4

__Proposer__: maximilian.summe at dfinity.org

__Source code__: [250daf4dd0cf7ea74c496b45457dd47ced16368c][new-commit]

[new-commit]: https://github.com/dfinity/ic/tree/250daf4dd0cf7ea74c496b45457dd47ced16368c


## Features & Fixes

###  Changed

- Use the mint_cycles128 system API, so larger amounts of cycles can now be minted.


## New Commits

```
$ git log --format="%C(auto) %h %s" 8ac2131be1a86e1267e7774b0c94085fc107bad3..250daf4dd0cf7ea74c496b45457dd47ced16368c --  ./rs/nns/cmc
 8b78380f83 feat: [EXC-1824] Use mint_cycles128 in CMC (#5317)
 4be4307321 feat(governance): Added `use ic_cdk::println;` to files that lack it. (#5233)
```


## Upgrade Arguments

```candid
()
```


## Current Version

__Current git hash__: 8ac2131be1a86e1267e7774b0c94085fc107bad3

__Current wasm hash__: c2fcf59b5c2edb3b0e334a9ed11d3dba24a032531e2e7707a265a8fe11e09bbd


## Verification

See the general instructions on [how to verify] proposals like this. A "quick
start" guide is provided here.

[how to verify]: https://github.com/dfinity/ic/tree/250daf4dd0cf7ea74c496b45457dd47ced16368c/rs/nervous_system/docs/proposal_verification.md


### WASM Verification

See ["Building the code"][prereqs] for prerequisites.

[prereqs]: https://github.com/dfinity/ic/tree/250daf4dd0cf7ea74c496b45457dd47ced16368c/README.adoc#building-the-code

```
# 1. Get a copy of the code.
git clone git@github.com:dfinity/ic.git
cd ic
# Or, if you already have a copy of the ic repo,
git fetch
git checkout 250daf4dd0cf7ea74c496b45457dd47ced16368c

# 2. Build canisters.
./ci/container/build-ic.sh -c

# 3. Fingerprint the result.
sha256sum ./artifacts/canisters/cycles-minting-canister.wasm.gz
```

This should match `wasm_module_hash` field of this proposal.


### Upgrade Arguments Verification

[`didc`][latest-didc] is required.

[latest-didc]: https://github.com/dfinity/candid/releases/latest

```
didc encode '()' | xxd -r -p | sha256sum

```

This should match the `arg_hash` field of this proposal.

Governance

# Upgrade the Governance Canister to Commit 250daf4

__Proposer__: maximilian.summe at dfinity.org

__Source code__: [250daf4dd0cf7ea74c496b45457dd47ced16368c][new-commit]

[new-commit]: https://github.com/dfinity/ic/tree/250daf4dd0cf7ea74c496b45457dd47ced16368c


## Features & Fixes

###  Added

* Expose a new metric `voting_power_snapshots_latest_snapshot_is_spike`.
* Enabling `DisburseMaturity` neuron management proposals.

###  Changed

* `MAX_NEURON_CREATION_SPIKE` is increased from 120 to 300.


## New Commits

```
$ git log --format="%C(auto) %h %s" 0dc5478d5aa69bfae7878543cb25d4ace362db0c..250daf4dd0cf7ea74c496b45457dd47ced16368c --  ./rs/nns/governance ./rs/sns/init
 250daf4dd0 feat(nns): Enable disburse maturity through neuron management proposals (#5157)
 fd295a030e feat(nns): Expose a metric voting_power_snapshots_latest_snapshot_is_spike (#5179)
 6b847e22fd feat: Increase MAX_NEURON_CREATION_SPIKE to 20 hours worth of neurons (#5335)
 8d8e832b03 test(nns): add maturity disbursement tla model and code link (#5225)
 4b308ddd8b feat(sns): inactive status of SNS api (#5217)
 16825c5cbf chore(nervous-system): Update changelog for release 2025-05-21 (#5247)
 7a51c90946 chore(governance): Clean up more leftovers from merge_maturity (#5245)
 4be4307321 feat(governance): Added `use ic_cdk::println;` to files that lack it. (#5233)
 986a0c95ba revert: "refactor(nns): Make ExchangeRate proposals obsolete (#5011)" (#5163)
```


## Current Version

__Current git hash__: 0dc5478d5aa69bfae7878543cb25d4ace362db0c

__Current wasm hash__: b5a749886a455340c46ad3f3baaf3c4154a64329403966d4367f8225338e2681


## Verification

See the general instructions on [how to verify] proposals like this. A "quick
start" guide is provided here.

[how to verify]: https://github.com/dfinity/ic/tree/250daf4dd0cf7ea74c496b45457dd47ced16368c/rs/nervous_system/docs/proposal_verification.md


### WASM Verification

See ["Building the code"][prereqs] for prerequisites.

[prereqs]: https://github.com/dfinity/ic/tree/250daf4dd0cf7ea74c496b45457dd47ced16368c/README.adoc#building-the-code

```
# 1. Get a copy of the code.
git clone git@github.com:dfinity/ic.git
cd ic
# Or, if you already have a copy of the ic repo,
git fetch
git checkout 250daf4dd0cf7ea74c496b45457dd47ced16368c

# 2. Build canisters.
./ci/container/build-ic.sh -c

# 3. Fingerprint the result.
sha256sum ./artifacts/canisters/governance-canister.wasm.gz
```

This should match `wasm_module_hash` field of this proposal.

Registry

# Upgrade the Registry Canister to Commit 250daf4

__Proposer__: maximilian.summe at dfinity.org

__Source code__: [250daf4dd0cf7ea74c496b45457dd47ced16368c][new-commit]

[new-commit]: https://github.com/dfinity/ic/tree/250daf4dd0cf7ea74c496b45457dd47ced16368c


## Features & Fixes

Maintenance Release, no major changes.

## New Commits

```
$ git log --format="%C(auto) %h %s" 8ac2131be1a86e1267e7774b0c94085fc107bad3..250daf4dd0cf7ea74c496b45457dd47ced16368c --  ./rs/registry/canister
 ed3650da85 chore(registry): Rename RegistryTransportRecord -> RegistryRecord (#5281)
 16825c5cbf chore(nervous-system): Update changelog for release 2025-05-21 (#5247)
 4be4307321 feat(governance): Added `use ic_cdk::println;` to files that lack it. (#5233)
 72a54263ac test(registry): More tests for large records/chunking. (#5178)
 05fdb3a476 fix: timestamps in nanoseconds in the registry  (#5076)
```


## Current Version

__Current git hash__: 8ac2131be1a86e1267e7774b0c94085fc107bad3

__Current wasm hash__: 5387c3deef80c1ca858127780837a7c8a715655ecb3b97de94881d0eeb9db793


## Verification

See the general instructions on [how to verify] proposals like this. A "quick
start" guide is provided here.

[how to verify]: https://github.com/dfinity/ic/tree/250daf4dd0cf7ea74c496b45457dd47ced16368c/rs/nervous_system/docs/proposal_verification.md


### WASM Verification

See ["Building the code"][prereqs] for prerequisites.

[prereqs]: https://github.com/dfinity/ic/tree/250daf4dd0cf7ea74c496b45457dd47ced16368c/README.adoc#building-the-code

```
# 1. Get a copy of the code.
git clone git@github.com:dfinity/ic.git
cd ic
# Or, if you already have a copy of the ic repo,
git fetch
git checkout 250daf4dd0cf7ea74c496b45457dd47ced16368c

# 2. Build canisters.
./ci/container/build-ic.sh -c

# 3. Fingerprint the result.
sha256sum ./artifacts/canisters/registry-canister.wasm.gz
```

This should match `wasm_module_hash` field of this proposal.

[timk11]

Hi @msumme. Thanks for the update! Are you or someone in the team able to answer these questions that came up in another thread regarding NNS canister upgrades?

@timk11

…what sort of testing process is usually done prior to submitting canister management proposals? Is this the sort of bug that would typically be detected in this way? (And I do appreciate that not everything can be foreseen.) Anything you would like us as reviewers to do differently?

@jasonzhu @aterga @daniel-wong @lara

[timk11]

Proposal 136795 | Tim - CodeGov

Vote: Adopt

Reason: Build is successful, hashes match, commits match descriptions and the reasoning behind the changes is sound. New commits are reviewed below.

[250daf4dd0]
Adapts Governance::validate_manage_neuron_proposal to allow maturity disbursement through Neuron Management proposals and checks that the to_account field is valid + related test changes.

[fd295a030e]
Adds metric voting_power_snapshots_latest_snapshot_is_spike, intended to indicate whether the latest voting power snapshot is a spike compared to previous snapshots, and a corresponding canbench benchmark voting_power_snapshots_is_latest_snapshot_a_spike.

[6b847e22fd]
Increases MAX_NEURON_CREATION_SPIKE (for the maximum number of neurons that can be created in a spike) from MAX_SUSTAINED_NEURONS_PER_HOUR * 8 to MAX_SUSTAINED_NEURONS_PER_HOUR * 20, as per description.

[8d8e832b03]
Adds TLA models (a verification and bug-finding tool for complex systems) for maturity disbursement in the NNS, along with further improvements to the existing TLA instrumentation as outlined in the commit notes.

[4b308ddd8b]
Adds a get_metrics query function to return an optional Metrics record for a given SNS containing num_recently_submitted_proposals and last_ledger_block_timestamp.

[16825c5cbf]
Updates changelogs for the current release.

[7a51c90946]
Removes code related to the now unused MergeMaturityResponse type and adapts one test accordingly.

[4be4307321]
Adds use ic_cdk::println, use self::println or use ic_cdk::eprintln to ensure that logs and errors are displayed correctly and adjusts dependencies accordingly.

[986a0c95ba]
Reverts commit c605cfaa17 which removed code related to the now obsolete exchange rate proposal topic and adapted NnsFunction::check_obsolete to return an error in the event this proposal topic was used.

Proposal 136796

Vote: Adopt

Reason: Build is successful, hashes match, commits match descriptions and the reasoning behind the changes is sound. New commits are reviewed below.

[ed3650da85]
Renames type RegistryTransportRecord to RegistryRecord, method get_changes_since_as_transport_records to get_changes_since_as_registry_records and function registry_deltas_to_registry_transport_records to registry_deltas_to_registry_records.

[72a54263ac]
Adds tests related to chunking and modifies other tests to enable chunkifying large values.

[05fdb3a476]
Switches timestamp_seconds to timestamp_nanoseconds in several code sections + related code and test changes.

Proposal 136797

Vote: Adopt

Reason: Build is successful, hashes and args match, commits match descriptions and the reasoning behind the changes is sound. There is one new commit, reviewed below.

[8b78380f83]
Modifies the cycles minting canister to use call_with_payment128 and canister_balance128 from the ic-cdk API.

About CodeGov

CodeGov has a team of developers who review and vote independently on the following proposal topics: IC-OS Version Election, Protocol Canister Management, Subnet Management, API Boundary Node Management, Node Admin, and Participant Management. The CodeGov NNS known neuron is configured to follow our reviewers on these technical topics. We also have a group of Followees who vote independently on the Governance and the SNS & Neurons’ Fund topics. We strive to be a credible and reliable Followee option that votes on every proposal and every proposal topic in the NNS. We also support decentralisation of SNS projects such as WaterNeuron, KongSwap, and Alice with a known neuron and credible Followees.

Learn more about CodeGov and its mission at codegov.org.

[1eo]

Adopt 136795

Proposal

• The upgrade args correspond to the empty args.
• The install mode is indeed upgrade.
• The wasm hash are reproducible.

Code Review

[250daf4dd0] Enable neuron management proposals with a DisburseMaturity command when the to_account field is valid.
[fd295a030e] Add a metric voting_power_snapshots_latest_snapshot_is_spike as a voting power snapshot can take a lot of space.
[6b847e22fd] Increase MAX_NEURON_CREATION_SPIKE from 120 to 300, it limits the number of new neurons that can be created.
[8d8e832b03] Update tla model to also account for maturity disbursement.
[4b308ddd8b] Allows an SNS to become inactive, which is helpful for frontends.
[16825c5cbf] Update changelogs.
[7a51c90946] Removes more dead code of merge_maturity code.
[4be4307321] Make sure that it’s the ic-cdk println! being called in tests.
[986a0c95ba] Revert a commit that made exchange rate proposals obsolete.

---

Adopt 136796

Proposal

• The upgrade args correspond to the empty args.
• The install mode is indeed upgrade.
• The wasm hash are reproducible.

Code Review

[ed3650da85] Rename RegistryTransportRecord to RegistryRecord
[16825c5cbf] Update Changelog
[4be4307321] Make sure that it’s the ic-cdk println! being called in tests.
[72a54263ac] Adds tests for chunking in rs/registry and rs/nns, slightly lowering the chunking threshold (with no release impact), and confirming readiness to enable chunking via a feature flag.
[05fdb3a476] Aligns the naming of timestamps and units being used (nanoseconds).

---

Adopt 136797

Proposal

• The upgrade args correspond to the empty args.
• The install mode is indeed upgrade.
• The wasm hash are reproducible.

Code Review

8b78380f83: Use mint_cycles128 in CMC
4be4307321: Make sure that it’s the ic-cdk println! being called in tests.

[cyberowl]

proposals - [136795, 136796, 136797] Cyberowl | CodeGov

Proposals:

136795
136796
136797

Vote: [ADOPT, ADOPT, ADOPT]

Reason & Feedback:

test(nns): add maturity disbursement tla model and code link (#5225) ·...

I successfully built and verified the hash. All the commit descriptions match their code changes.

Checks:

Hash Match: [PASS, PASS, PASS]
Target Canister: [PASS, PASS, PASS]
Proposer Check: [PASS, PASS, PASS]

Overall Summary:

Adds support for DisburseMaturity neuron‐management proposals by validating any provided to_account as a proper ICRC‐1 account.
Replaces all timestamp_seconds fields with timestamp_nanoseconds across the registry canister, updating protobuf definitions, Rust types, internal functions now_nanoseconds(). Replaces all 64-bit cycle‐minting and payment calls with their 128-bit counterparts.

Commits Summary

proposal / 136795

250daf4dd0
Adds support for DisburseMaturity neuron‐management proposals by validating any provided to_account as a proper ICRC‐1 account and returning an InvalidCommand error if it fails. Integration tests for creating neurons with maturity, proposing DisburseMaturity, and verifying that after 7 days the promised funds arrive at the destination and the in‐flight disbursement is cleared.

fd295a030e
Added a CanBench benchmark for is_latest_snapshot_a_spike and exposed a new gauge metric voting_power_snapshots_latest_snapshot_is_spik.

6b847e22fd
Matches commit description Increase MAX_NEURON_CREATION_SPIKE to 20 hours worth of neurons.

8d8e832b03
Integrated TLA+ instrumentation into the governance canister by adding support for maturity‐disbursement and its timer (including new TLA models, snapshotter macros, updated tracing store, and a get_tla_traces query), updated BUILD files and tests to enable Apalache checks.

4b308ddd8b
Add a new get_metrics composite query to the SNS governance.

16825c5cbf
Update change log.

7a51c90946
Removes all MergeMaturity logic eliminating its response type and associated methods.

4be4307321
Adds ic-cdk (version 0.17.2) as a dependency in multiple crates. Injects println/eprintln calls to enable on-chain logging.

986a0c95ba
Removes all IcpXdrConversionRate proposal handling—deleting its validation logic, payloads, API, tests, and integration references—and marks it as obsolete.

proposal / 136796

ed3650da85
Rename and cleanup, “transport” terminology has been dropped in favor of the simpler RegistryRecord name.

72a54263ac
Adjusts the count_fitting_deltas tests to reflect how oversized mutations get split into smaller chunks, and adds new panic-and non-panic test cases for mutations right around the size limits. It also makes MAX_CHUNKABLE_ATOMIC_MUTATION_LEN public and tweaks the chunk-vs-inline threshold constants so that values just under or over the limit behave as expected.

05fdb3a476
Replaces all timestamp_seconds fields with timestamp_nanoseconds across the registry canister, updating protobuf definitions, Rust types, internal functions now_nanoseconds().

proposal / 136797

8b78380f83
Replaces all 64-bit cycle‐minting and payment calls with their 128-bit counterparts, swapping mint_cycles/call_with_payment for mint_cycles128/call_with_payment128 and using canister_balance128.

About CodeGov

CodeGov has a team of developers who review and vote independently on the following proposal topics: IC-OS Version Election, Protocol Canister Management, Subnet Management, Node Admin, and Participant Management. The CodeGov NNS known neuron is configured to follow our reviewers on these technical topics. We also have a group of Followees who vote independently on the Governance and the SNS & Neuron’s Fund topics. We strive to be a credible and reliable Followee option that votes on every proposal and every proposal topic in the NNS. We also support decentralization of SNS projects such as WaterNeuron, KongSwap, and Alice with a known neuron and credible Followees.

Learn more about CodeGov and its mission at codegov.org.

[msumme]

Hi @timk11 - I posted a reply on another thread. LMK if that doesn’t answer your question:

NNS governance - bug in proposal 136693

Hi all - a few people have asked about why this wasn’t caught during testing. This is a great question, and of course one that immediately came up on the team as well. The basic answer is that there wasn’t an existing test in place and the same mistake that led to the error also resulted in not having a test. The data migration got missed due to human error. Existing tests couldn’t have caught something about the new field that was introduced (because it wasn’t there). New tests ensured the …

[LaCosta]

Proposal 136795 – LaCosta | CodeGov

Vote: ADOPT

Governance Canister

Reason:
Build successful and hashes match, commits look great and match the description. Found no issues.

[250daf4dd0]: Updates the function validate_manage_neuron_proposal to accept DisburseMaturity commands instead of returning an error as previously since DisburseMaturity is enabled checking the to_account field.

[fd295a030e]: Adds a new metric voting_power_snapshots_is_latest_snapshot_a_spike to the encode_metrics function that indicates if the latest voting power snapshot was a spike. A new benchamrk voting_power_snapshots_is_latest_snapshot_a_spike is also added using canbench_rs

[6b847e22fd]: Increases MAX_NEURON_CREATION_SPIKE from MAX_SUSTAINED_NEURONS_PER_HOUR * 8 to AX_SUSTAINED_NEURONS_PER_HOUR * 20

[8d8e832b03]: Adds a TLA+ model for the maturity disbursement functionality and improves the TLA+ instrumentation for future changes.

[4b308ddd8b]: Adds a query function to the SNS Governance that returns metrics of a given SNS over a time window. The metrics returned are num_recently_submitted_proposals and last_ledger_block_timestamp

[16825c5cbf]: Updates change logs to include adopted proposals and corresponding changes.

[7a51c90946]: Removes code related to MergeMaturityResponse that has remained unused for over a year. Adapts test test_merge_maturity_returns_expected_error accordingly.

[4be4307321]: Adds use ic_cdk::println; in every file that uses println! or eprintln! and lacked this import. To avoid version errors/ambiguity in test modules it adds use self::println;

[986a0c95ba]: Reverts commit c605cfa that made ExnchangeRate proposals obsolete since it failed test //rs/tests/nns:nns_cycles_minting_test. Adapts the match NnsFunction::IcpXdrConversionRate to throw an invalid_proposal_error.

Proposal 136796 – LaCosta | CodeGov

Vote: ADOPT

Registry Canister

Reason:
Build successful and hashes match, commits look great and match the description. Found no issues.

Contains duplicate commits from previous proposals

[ed3650da85]: Renames RegistryTransportRecord to RegistryRecord

[72a54263ac]: Adds tests and improves existing ones for chunking. It also slihhgtly adjusts the minimum chunkable size, though with no release impact.

[05fdb3a476]: Fixed an error where the variable timestamp_seconds store time in nanoseconds, so it was renamed to timestamp_nanoseconds. It also addresses comments left in a previous PR

Proposal 136797 – LaCosta | CodeGov

Vote: ADOPT

Cycles-minting Canister

Reason:
Build successful and hashes match, commits look great and match the description. Found no issues.

Contains duplicate commits from previous proposals

[8b78380f83]: Modifies the CMC to use mint_cycles128 and call_with_payment128 instead of the 64-bit variants.

About CodeGov

CodeGov has a team of developers who review and vote independently on the following proposal topics: IC-OS Version Election, Protocol Canister Management, Subnet Management, Node Admin, and Participant Management. The CodeGov NNS known neuron is configured to follow our reviewers on these technical topics. We also have a group of Followees who vote independently on the Governance and the SNS & Neuron’s Fund topics. We strive to be a credible and reliable Followee option that votes on every proposal and every proposal topic in the NNS. We also support decentralization of SNS projects such as WaterNeuron, KongSwap, and Alice with a known neuron and credible Followees.

Learn more about CodeGov and its mission at codegov.org.