NNS Updates 2025-02-07

[jasonzhu]

The NNS Team submitted the following proposals. DFINITY plans to vote on these proposals the following Monday.

• https://dashboard.internetcomputer.org/proposal/135205
• https://dashboard.internetcomputer.org/proposal/135206
• https://dashboard.internetcomputer.org/proposal/135207

Proposals to be Submitted

Cycles-minting

# Upgrade the Cycles-minting Canister to Commit 2d4bcba

__Proposer__: jason.zhu at dfinity.org

__Source code__: [2d4bcba47ea10520ff21ce54a8acb9cdb0629317][new-commit]

[new-commit]: https://github.com/dfinity/ic/tree/2d4bcba47ea10520ff21ce54a8acb9cdb0629317


## Features & Fixes

###  Added

* Automatically refund when the memo in an incoming ICP transfer is not one of
  the special values that indicate the purpose of the transfer (e.g. to create a
  new canister). This was originally proposed without objection in [the forum].

[the forum]: https://forum.dfinity.org/t/extend-cycles-minting-canister-functionality/37749/2


## New Commits

```
$ git log --format="%C(auto) %h %s" b5192581ccd35b67fe5a1f795ead9cbcd25956d6..2d4bcba47ea10520ff21ce54a8acb9cdb0629317 --  ./rs/nns/cmc
 5506c7c41e chore: [EXC-1835] Make ic-management-canister-types private (#3814)
 ae3ab5aa3c refactor(nervous-system): Move Request implementations from canister crates to rs/nervous_system/agent (#3657)
 0ac8a60bc9 feat(cycles-minting-canister): Enabled automatic refunds. (#3632)
 8f4c5bbf3f docs(cmc): Fixed a comment in CMC automatic refund. (#3634)
 5c68a63660 feat(ic-nervous-system-agent): Add management canister functions (#3591)
 03393bc817 feat(cycles-minting): Cycles Minting canister refunds automatically. (#3484)
```


## Upgrade Arguments

```candid
()
```


## Current Version

__Current git hash__: b5192581ccd35b67fe5a1f795ead9cbcd25956d6

__Current wasm hash__: 11c8dedd11741f05990498c90f925e9e37ad60647a65ef47caa59cdba234be6f


## Verification

See the general instructions on [how to verify] proposals like this. A "quick
start" guide is provided here.

[how to verify]: https://github.com/dfinity/ic/tree/2d4bcba47ea10520ff21ce54a8acb9cdb0629317/rs/nervous_system/docs/proposal_verification.md


### WASM Verification

See ["Building the code"][prereqs] for prerequisites.

[prereqs]: https://github.com/dfinity/ic/tree/2d4bcba47ea10520ff21ce54a8acb9cdb0629317/README.adoc#building-the-code

```
# 1. Get a copy of the code.
git clone git@github.com:dfinity/ic.git
cd ic
# Or, if you already have a copy of the ic repo,
git fetch
git checkout 2d4bcba47ea10520ff21ce54a8acb9cdb0629317

# 2. Build canisters.
./ci/container/build-ic.sh -c

# 3. Fingerprint the result.
sha256sum ./artifacts/canisters/cycles-minting-canister.wasm.gz
```

This should match `wasm_module_hash` field of this proposal.


### Upgrade Arguments Verification

[`didc`][latest-didc] is required.

[latest-didc]: https://github.com/dfinity/candid/releases/latest

```
didc encode '()' | xxd -r -p | sha256sum

```

This should match the `arg_hash` field of this proposal.

Governance

# Upgrade the Governance Canister to Commit 2d4bcba

__Proposer__: jason.zhu at dfinity.org

__Source code__: [2d4bcba47ea10520ff21ce54a8acb9cdb0629317][new-commit]

[new-commit]: https://github.com/dfinity/ic/tree/2d4bcba47ea10520ff21ce54a8acb9cdb0629317


## Features & Fixes

###  Added

####  List Neurons API Change: Query by Subaccount

The `list_neurons` API now supports querying by neuron subaccount.  This is useful for neuron holders who
have many neurons and want to list only the neurons associated with a particular subaccount.

A new field `neuron_subaccounts` is added to the request, which is a list of subaccounts to query
for.  If this field is present, any neurons found will be added to the response.  If duplicate
neurons are found between this field and others, they will be deduplicated before returning the value.

This new field works in the same way that the existing `neuron_ids` field works.

####  Migrating Active Neurons to Stable Memory

In this release, we turn on the feature to migrate active neurons to stable memory:
`migrate_active_neurons_to_stable_memory`. After the feature is turned on, a timer task will
gradually move active neurons from the heap to stable memory. Clients should not expect any
functional behavior changes, since no APIs rely on where the neurons are stored.

###  Changed

* The limit of the number of neurons is increased from 380K to 400K.


## New Commits

```
$ git log --format="%C(auto) %h %s" c5e098e8cc8e62249e6d7f4ed09e6c2ed87fc800..2d4bcba47ea10520ff21ce54a8acb9cdb0629317 --  ./rs/nns/governance ./rs/sns/init
 a3ef9a55e4 feat(nns): Turn on the feature to migrate neurons to stable memory (#3864)
 dba1fcc0bc chore(nns): Remove changelog entries which are already copied to CHANGELOG.md (#3865)
 0c590b1dd7 docs(nns): Updated comment about following pruning batches. (#3772)
 5506c7c41e chore: [EXC-1835] Make ic-management-canister-types private (#3814)
 90acaff3bc chore(nns): Clean up the migration code to backfill InstallCode hashes (#3809)
 5acf43fb09 feat(sns): Do not store logos in SNS initialization parameters to save space (#3786)
 36c6abf7e8 perf(nns): Set NNS Governance governance noise threshold to 5% (#3766)
 fa247dff11 chore(nervous-system): Release on 2025-02-03 (#3735)
 03230898e8 refactor(nns): Follow up on PR 3090 (#3773)
 413a393dd6 feat(nns): list_neurons supports querying by subaccount (#3592)
 acb62c3efe docs(nns): Added a TODO with Jira ticket ID about the demise of refresh neuron flags. (#3783)
 9dd1f0ceb0 chore(nns): Deleted set_initial_voting_power_economics. (#3778)
 8c3920c149 chore(nns): Deleted backfilling voting_power_refreshed_timestamp. (#3780)
 134fbac885 docs(nns): Follow up on PR 2339 (#3771)
 fd7cd5a125 chore(nns): Modify the comment on `include_empty_neurons_readable_by_caller` (#3740)
 3afdf372a9 feat(IC-1579): Governance: TLA Codelink for refresh_neuron (#3547)
 30b3069b8c chore: allow automatically replacing a node even if it is active as an API BN (#3707)
 156e27ae42 docs(nns): Created entry in Governance's CHANGELOG for proposal 134777 (Jan 10). (#3732)
 796a902752 feat(nns): Bump neurons limit (#3739)
 5bea1df380 chore(governance): Remove unused types (#3711)
```


## Current Version

__Current git hash__: c5e098e8cc8e62249e6d7f4ed09e6c2ed87fc800

__Current wasm hash__: bd821399f16d4bdac8cef06b81d8ac72cf8e36a7ab766efccb2a0925be6f388f


## Verification

See the general instructions on [how to verify] proposals like this. A "quick
start" guide is provided here.

[how to verify]: https://github.com/dfinity/ic/tree/2d4bcba47ea10520ff21ce54a8acb9cdb0629317/rs/nervous_system/docs/proposal_verification.md


### WASM Verification

See ["Building the code"][prereqs] for prerequisites.

[prereqs]: https://github.com/dfinity/ic/tree/2d4bcba47ea10520ff21ce54a8acb9cdb0629317/README.adoc#building-the-code

```
# 1. Get a copy of the code.
git clone git@github.com:dfinity/ic.git
cd ic
# Or, if you already have a copy of the ic repo,
git fetch
git checkout 2d4bcba47ea10520ff21ce54a8acb9cdb0629317

# 2. Build canisters.
./ci/container/build-ic.sh -c

# 3. Fingerprint the result.
sha256sum ./artifacts/canisters/governance-canister.wasm.gz
```

This should match `wasm_module_hash` field of this proposal.

Registry

# Upgrade the Registry Canister to Commit 2d4bcba

__Proposer__: jason.zhu at dfinity.org

__Source code__: [2d4bcba47ea10520ff21ce54a8acb9cdb0629317][new-commit]

[new-commit]: https://github.com/dfinity/ic/tree/2d4bcba47ea10520ff21ce54a8acb9cdb0629317


## Features & Fixes

###  Changed

####  Migrate Registry to use ic_stable_structures' MemoryManager

This update migrates registry from using dfn_core to using virtual memory regions provided by ic_stable_structures
MemoryManager.  This allows in the future to migrate the Registry records into stable memory.

####  Automatically replace the nodes when an active API boundary node is replaced

`add_node` will now also automatically replace a node if it is being redeployed and has
been active as an API boundary node before. It will fail if the redeployed node does not
meet the requirements for an API boundary node (i.e., is configured with a domain name).

###  Deprecated

The legacy ECDSA-specific fields are no longer supported in Registry canister's subnet operations
(creation, updating, recovery). Please use the more expressive chain key configuration keys:

* `ecdsa_config` → `chain_key_config`
* `ecdsa_key_signing_enable` → `chain_key_signing_enable`
* `ecdsa_key_signing_disable` → `chain_key_signing_disable`

###  Fixed

####  Backfill node_reward_type for existing nodes

A one-time migration to fill in the `node_reward_type` field for existing nodes was added.  Previously, there was no
on-chain connection between the specific nodes and their reward types.  This data came from off-chain sources
at DFINITY.  In the future, the `node_reward_type` will be used to determine the reward type for each node, and
it will be a required field for node registration in the IC.


## New Commits

```
$ git log --format="%C(auto) %h %s" a5878586e47536d4cd47f0aadb66b73df8131d2b..2d4bcba47ea10520ff21ce54a8acb9cdb0629317 --  ./rs/registry/canister
 5506c7c41e chore: [EXC-1835] Make ic-management-canister-types private (#3814)
 5e85addd44 chore(registry): Remove obsolete ECDSA API (#3827)
 0206830a65 test(btc): Port ckBTC tests from legacy ECDSA to chain key Registry API (#3820)
 b803bf020c feat(registry): Obsolete legacy ECDSA configs (#3709)
 30b3069b8c chore: allow automatically replacing a node even if it is active as an API BN (#3707)
 ec6e895aef refactor(registry): Migrate Registry to use MemoryManager instead of raw stable memory (#3700)
 ae3ab5aa3c refactor(nervous-system): Move Request implementations from canister crates to rs/nervous_system/agent (#3657)
 6d4ecc89e1 chore(registry): Backfill missing node_reward_type records (#3589)
 5c68a63660 feat(ic-nervous-system-agent): Add management canister functions (#3591)
 69748856b6 refactor: Use Principal in RemoveNodeOperatorsPayload, instead of Vec<u8> (#3386)
 f569791cc7 docs(governance): Added 2025-01-20 CHANGELOG.md entries. (#3535)
```


## Current Version

__Current git hash__: a5878586e47536d4cd47f0aadb66b73df8131d2b

__Current wasm hash__: f0fb8fa545b2cc68f030b040e1182a8d004c4d4f4bb4341c9f1b432642c85bef


## Verification

See the general instructions on [how to verify] proposals like this. A "quick
start" guide is provided here.

[how to verify]: https://github.com/dfinity/ic/tree/2d4bcba47ea10520ff21ce54a8acb9cdb0629317/rs/nervous_system/docs/proposal_verification.md


### WASM Verification

See ["Building the code"][prereqs] for prerequisites.

[prereqs]: https://github.com/dfinity/ic/tree/2d4bcba47ea10520ff21ce54a8acb9cdb0629317/README.adoc#building-the-code

```
# 1. Get a copy of the code.
git clone git@github.com:dfinity/ic.git
cd ic
# Or, if you already have a copy of the ic repo,
git fetch
git checkout 2d4bcba47ea10520ff21ce54a8acb9cdb0629317

# 2. Build canisters.
./ci/container/build-ic.sh -c

# 3. Fingerprint the result.
sha256sum ./artifacts/canisters/registry-canister.wasm.gz
```

This should match `wasm_module_hash` field of this proposal.

[1eo]

Approve Proposal 135205

Proposal

• Canister id rkp4c-7iaaa-aaaaa-aaaca-cai is indeed the cycle minting canister.
• The upgrade args correspond to the empty args.
• The install mode is indeed upgrade.
• The wasm hash is reproducible.

Code Review

• The get_u64_memo function is well-implemented and effectively converts a memo to a u64. Great job on that!

• The use of IS_AUTOMATIC_REFUND_ENABLED could be reconsidered. It seems like it might be more appropriate to use a feature flag or even remove this check entirely if it’s always true. This would simplify the code and make it more production-ready.

• The current approach to refunding a block is quite complex and could be error-prone. Specifically, the intermediary state AlreadyProcessing might not be necessary and could introduce potential issues. Simplifying this process could make the code more robust and easier to maintain.

• The issue_automatic_refund_if_memo_not_offerred function is on the right track but could be streamlined to make it easier to review and understand.

General Recommendations:

Consider leveraging stable structures more effectively. Using the pre_upgrade hook is generally not recommended for DFINITY canisters, as it can lead to complications. Avoiding this practice can help set a good example for the community.

I am voting to adopt this as the new feature is present, but I am waiting for a follow-up proposal to remove IS_AUTOMATIC_REFUND_ENABLED and hopefully simplify the refund flow.

[1eo]

Approve Proposal 135206

Proposal

• Canister id rrkah-fqaaa-aaaaa-aaaaq-caii is indeed the governance canister.
• The upgrade args correspond to the empty args.
• The install mode is indeed upgrade.
• The wasm hash is reproducible.

Code Review

• The TLA model has been refreshed for the refresh_neuron function, ensuring it is up-to-date and accurate.
• Unnecessary code in nns/governance/src/pb/conversions.rs has been removed, streamlining the codebase and improving maintainability.
• The backfilling of voting_power_refreshed_timestamp has been deleted, simplifying the process and reducing redundancy.
• The list_neurons function now supports querying by subaccount. The API has been enhanced to accept a list of subaccounts, allowing for more flexible and targeted neuron retrieval.
• The MIGRATE_ACTIVE_NEURONS_TO_STABLE_MEMORY flag has been set to true, initiating the migration of active neurons to stable memory. This change will enhance the stability and reliability of the system.

[1eo]

Approve Proposal 135207

Proposal

• Canister id rwlgt-iiaaa-aaaaa-aaaaa-cai is indeed the registry canister.
• The upgrade args correspond to the empty args.
• The install mode is indeed upgrade.
• The wasm hash is reproducible.

Code Review

• The removal of the ecdsa_config field has simplified the codebase.
• The add_missing_node_types_to_nodes function will be executed during the post_upgrade phase of this canister. It maps each IC node to one of the following types: type0, type1, type3.1, or type3. The mapping can be found in rs/registry/canister/src/missing_node_types_map.rs. However, I am unsure how to verify the entries in this map.
• The add_node function has been improved to automatically replace a node if it is being redeployed and has previously served as an API boundary node. However, the operation will fail if the redeployed node does not meet the requirements for an API boundary node, such as being configured with a domain name.

[cyberowl]

proposal - 135205 – Cyberowl | CodeGov

Vote: ADOPT
Hash Match: MATCH
Feedback: NONE 
Proposer Check: MATCH
Reason: I successfully built and verified the hash. All the commit descriptions match their code changes.

Commits Summary

5506c7c41e
All references to the crate ic-management-canister-types have been replaced with ic-management-canister-types-private.

ae3ab5aa3c
Replaces all references to the old SNS governance crate with the new “ic-sns-governance-api” dependency. Updated to reference the new SNS governance API package instead of the old one.

0ac8a60bc9
By default, the canister will now automatically refund ICP transfers that do not have one of the recognized memos.

8f4c5bbf3f
Fix comment.

5c68a63660
Replaces references to "ic-sns-governance" with "ic-sns-governance-api" and adding new dependencies (e.g. "cycles-minting-canister", "ic-nervous-system-clients", and "registry-canister"). A new module, management_canister, has been introduced in the nervous system agent. This module encapsulates request types and helper functions, such as for chunked Wasm uploads and retrieving stored chunks.

03393bc817
Add new dependencies such as "maplit" and "ic-test-utilities-metrics". Code now uses block-status synchronization to avoid duplicate processing and to correctly handle cases where the transaction’s memo is not one of the predefined “meaningful” memos, ensuring proper error reporting and refund behavior.

proposal - 135206 – Cyberowl | CodeGov

Vote: ADOPT
Hash Match: MATCH
Feedback: NONE 
Proposer Check: MATCH
Reason: I successfully built and verified the hash. All the commit descriptions match their code changes.

Commits Summary

a3ef9a55e4
Matches description Turn on the feature to migrate neurons to stable memory.

dba1fcc0bc
Matches description Remove changelog entries.

0c590b1dd7
Matches description Updated comment about following pruning batches..

5506c7c41e
DUPLICATE

90acaff3bc
Remove function backfill_install_code_hashes

5acf43fb09
Removes logo from sns_initialization_parameters to save space.

36c6abf7e8
Matches description Set NNS Governance governance noise threshold to 5% .

fa247dff11
Adjust release notes for various proposals and add new entries that describe new features and changes (such as migration features for active neurons, paging support for neuron listings, and enhancements to SNS governance behavior).

03230898e8
Refactors how the voting power decline is calculated by replacing separate boolean checks with a single subtraction using checked_sub, and it returns early if the subtraction fails. The comments were updated for clarity.

413a393dd6
A new field called neuron_subaccounts has been added to the ListNeurons API (both in the protobuf and candid definitions) so that requests can now specify a list of neuron subaccounts to filter neurons, alongside the existing neuron_ids field.

acb62c3efe
Fix Comment

9dd1f0ceb0
Delete set_initial_voting_power_economics

8c3920c149
Delete backfill_some_voting_power_refreshed_timestamps

134fbac885
Instead of using a default round(), the code now explicitly calls round_dp_with_strategy(0, RoundingStrategy::MidpointNearestEven) to control how the Decimal is converted back to u64.

fd7cd5a125
Fix Comment

3afdf372a9
Added TLA instrumentation support for neuron refreshing by exporting a new TLA descriptor REFRESH_NEURON_DESC and tagging the refresh_neuron function with a corresponding update attribute. Records the neuron id for better traceability.

30b3069b8c
When an active API boundary node is redeployed, the system will automatically replace the old node with the new one if it meets the domain requirements, otherwise the operation will fail.

156e27ae42
Added changelog for Proposal 134777

796a902752
Increase maximum number of neurons supported.

5bea1df380
Deleted protobuf messages and their conversion functions for claiming or refreshing a neuron from an account, and the canister now returns the governance response directly without mapping it to a custom NeuronInfo.

proposal - 135207 – Cyberowl | CodeGov

Vote: ADOPT
Hash Match: MATCH
Feedback: NONE 
Proposer Check: MATCH
Reason: I successfully built and verified the hash. All the commit descriptions match their code changes.

Commits Summary

5506c7c41e
DUPLICATE

5e85addd44
Removes all references to the deprecated ecdsa_config (and related key signing fields) from registry, canister, test, and protobuf code, replacing them with the newer chain_key_config field.

0206830a65
Removed all uses and conversions of the deprecated ECDSA configuration.

b803bf020c
This reverts previous commit that Obsolete legacy ECDSA configs. It had added migration logic that converts any legacy ECDSA configuration into the new chain key configuration while enforcing that new proposals use only the new fields.

30b3069b8c
DUPLICATE

ec6e895aef
Replaces direct dfn_core stable storage calls with a new abstraction (in a newly added storage.rs module) that uses the MemoryManager API from ic‑stable‑structures. The pre‑upgrade and post‑upgrade functions in the registry canister are updated to store and load their state using protobuf serialization through these new stable memory.

ae3ab5aa3c
DUPLICATE

6d4ecc89e1
Adds a one‐time migration that backfills the missing
node_reward_type field for existing node records.

5c68a63660
DUPLICATE

69748856b6
Removes Node Operators from the registry by introducing a new payload structure that uses principal types.

f569791cc7
Matches description Added 2025-01-20 CHANGELOG.md entries.

About

About CodeGov…(click to expand)

CodeGov has a team of developers who review and vote independently on the following proposal topics: IC-OS Version Election, Protocol Canister Management, Subnet Management, Node Admin, and Participant Management. The CodeGov NNS known neuron is configured to follow our reviewers on these topics and Synapse on most other topics. We strive to be a credible and reliable Followee option that votes on every proposal and every proposal topic in the NNS. We also support decentralization of SNS projects such as WaterNeuron and KongSwap with a known neuron and credible Followees.

Learn more about CodeGov and it’s mission at codegov.org.

[Zane]

Proposal 135205 - Zane | CodeGov

Vote: ADOPT
Reason: Build completes successfully, both hashes and reviewed commits match their descriptions, so I’ve decided voted to adopt.

5506c7c41e Renamed imports from types/management_canister_types to ic-management-canister-types-private.

ae3ab5aa3c Same as description.

0ac8a60bc9 Enabled automatic refunds feature flag and added code to cmc_notify_mint_cycles test to ensure the correct error variant and message are returned when IS_AUTOMATIC_REFUND_ENABLED is set to true.

8f4c5bbf3f Same as description.

5c68a63660 Added helper methods to ic-nervous-system-agent for chunked wasm upload, canister creation through the cycle minting canister, obtaining subnet id for a given canister by calling the registry and modified list_sns_canisters so it returns all SNS dapp canisters alonsgide the SNS system canisters.

03393bc817 Added functionality to automatically refund tokens if the memo provided doesn’t match a supported operation. This logic is gated behind IS_AUTOMATIC_REFUND_ENABLED flag.

Proposal 135206 - Zane | CodeGov

Vote: ADOPT
Reason: Build completes successfully, both hashes and reviewed commits match their descriptions, so I’ve decided voted to adopt.

a3ef9a55e4 Enabled MIGRATE_ACTIVE_NEURONS_TO_STABLE_MEMORY flag.

dba1fcc0bc Same as description.

0c590b1dd7 Same as description.

90acaff3bc Removed backfill_install_code_hashes method and its usage.

5acf43fb09 Added stringify_without_logos method to SnsInitPayload, which strips the sns and associated token logos from the serialized initialization parameters. It is called in governance_init_args when assigning a value to sns_initialization_parameters field.

36c6abf7e8 Same as description.

fa247dff11 Updated changelog and unreleased changelog files.

03230898e8 Moved comment and replaced checked_sub with < operator for voting power refresh checks.

413a393dd6 Added neuron_subaccounts field to ListNeurons struct, which is a list of subaccounts the caller want to get neurons for. Modified list_neurons method to fetch neurons for the given subaccounts and return them in the response.

acb62c3efe Same as description.

9dd1f0ceb0 Removed set_initial_voting_power_economics method, its usage and related tests.

8c3920c149 Removed backfill_some_voting_power_refreshed_timestamps method, its usage and related tests.

134fbac885 Added comment about deciding_voting_power_adjustment_factor functioning. In deciding_voting_power replaced round with round_dp_with_strategy.

fd7cd5a125 Same as description.

30b3069b8c Modified make_remove_or_replace_node_mutations method so that it is possible to replace a deployed boundary node, provided its replacement meets the requirements for being an API boundary node. If so the old node record is removed and a new one is created for the replacement. If no replacement is provided or the requirements are not met a panic is raised.

156e27ae42 Same as description.

796a902752 Increased MAX_NUMBER_OF_NEURONS from 380k to 400k.

5bea1df380 Deleted ClaimOrRefreshNeuronFromAccount and ClaimOrRefreshNeuronFromAccountResponse types alonsgide their proto definitions and conversion logic.

Proposal 135207 - Zane | CodeGov

Vote: ADOPT
Reason: Build completes successfully, both hashes and reviewed commits match their descriptions, so I’ve decided voted to adopt.

5e85addd44 Removed all references of ecdsa_config, added both the field name and its id to the list of reserved values in subnet.proto to prevent future collisions. Renamed new_without_ecdsa_config to new_without_chain_key_config and modified it to set chain_key_config field of subnet config.

0206830a65 Same as description.

b803bf020c Further cleanup of legacy ECDSA configs.

ec6e895aef Setup memory manager provided by ic_stable_structures library and reserve a memory id for upgrades. Pre/post upgrades hook have been modified to makes use of this more up to date API over the one provided by dfn_core. In the pre upgrade hook the logic has already been replaced, for this release the post upgrade hook still contains both new and legacy logic as it’s still need to decode the data serialized with dfn, following updates will make use of the upgrades memory instead.

6d4ecc89e1 Added MISSING_NODE_TYPES_MAP to global state, which is an associative map linking node ids to their respective reward type. Added add_missing_node_types_to_nodes to iterate over all node records in the registry and set their node_reward_type field if it is empty or unspecified by using MISSING_NODE_TYPES_MAP. The method is called by the post_upgrade hook.

69748856b6 Moved RemoveNodeOperatorsPayload definition from node_operator.proto to registry/canister/src/mutations/do_remove_node_operators.rs and extended it to include a vector of Principals to remove for better readability. Both representation of the principal, serialized and non, can be used at the moment, but providing both will panic.

f569791cc7 Same as description.

About CodeGov

CodeGov has a team of developers who review and vote independently on the following proposal topics: IC-OS Version Election, Protocol Canister Management, Subnet Management, Node Admin, and Participant Management. The CodeGov NNS known neuron is configured to follow our reviewers on these topics and Synapse on most other topics. We strive to be a credible and reliable Followee option that votes on every proposal and every proposal topic in the NNS. We also support decentralization of SNS projects such as WaterNeuron and KongSwap with a known neuron and credible Followees.

Learn more about CodeGov and its mission at codegov.org.

[LaCosta]

Proposal 135205 – LaCosta | CodeGov

Vote: ADOPT

Cycles-minting Canister

Reason:
Build successful and hashes match, commits look great and match the description. Found no issues.

[5506c7c41e]: Replaces all references to ic-management-canister-types with ic-management-canister-types-private since this types are made only for internal use and every other user should switch to use these types from a public crate.

[ae3ab5aa3c]: Replaces references to ic-sns-governance with ic-sns-governance-api and moves request implementations for canisters to their own requests.rs files in rs/nervous_system/agent.

[0ac8a60bc9]: Sets the constant IS_AUTOMATIC_REFUND_ENABLED to true by default enabling the automatic refunds when there is a bad memo implemented in a previous commit.

[8f4c5bbf3f]: Fixes a comment in issue_automatic_refund_if_memo_not_offerred

[5c68a63660]: Creates a new module management_canister which holds the logic for request types and some helper functions for the ic-nervous-system-agent.

[03393bc817]: Introduces new logic for refunding ICP when the memo is not recognized by the CMC. The logic is only active when the constant IS_AUTOMATIC_REFUND_ENABLED is set to true. The array MEANINGFUL_MEMOS holds the current supported operations by the CMC and can be expanded later on.

Proposal 135206 – LaCosta | CodeGov

Vote: ADOPT

Governance Canister

Reason:
Build successful and hashes match, commits look great and match the description. Found no issues.

[a3ef9a55e4]: Sets MIGRATE_ACTIVE_NEURONS_TO_STABLE_MEMORY to true, enabling the migration of neurons to stable memory.

[dba1fcc0bc]: Removes entries in the unreleased_changelog.md as they are already present in the CHANGELOG.md

[0c590b1dd7]: Fixes comments

[5506c7c41e]: Replaces all references to ic-management-canister-types with ic-management-canister-types-private since this types are made only for internal use and every other user should switch to use these types from a public crate.

[90acaff3bc]: Removes method backfill_install_code_hashes

[5acf43fb09]: Adds the method stringify_without_logos that modifies SnsInitPayload by replacing logos with the string <redacted-to-save-space>.

[36c6abf7e8]: Increases the noise_threshold from 2% to 5%

[fa247dff11]: Updates the CHANGELOG with proposal entries and new added logic.

[03230898e8]: Fixes spme comments and replaces the logic to detect if the right operand is greater using < instead of checked_sub which simplifies logic.

[413a393dd6]: Adds the field neuron_subaccounts to the ListNeurons API that allows callers to specify the subbacounts for which they want a list of neurons.

[acb62c3efe]: Adds a TODO comment

[9dd1f0ceb0]: Removes the mechanism for set_initial_voting_power_economics that sets the field voting_power_economics to DEFAULT_VOTING_POWER_ECONOMICS. IT was a one time use code so it can be removed.

[8c3920c149]: Removes the mechanism for backfilling the voting_power_refreshed_timestamp field for neurons since now that it has run once, it is not needed.

[134fbac885]: Updates some comments and switches from using round() when converting back to u64 to using round_dp_with_strategy which allows for a more variety of strategies, currently using MidpointNearestEven that rounds halfway cases up when the nearest integer in even.

[fd7cd5a125]: Fixes a comment regarding include_empty_neurons_readable_by_caller

[3afdf372a9]: Adds TLA+ models and instrumentation for refresh_neuron.

[30b3069b8c]: Implements logic to replace the node record an active boundary node when it is redeployed. Checks if it is redeployed meeting the domain requirements.

[156e27ae42]: Added an entry for Proposal 134777 in the CHANGELOG

[796a902752]: Increases the maximum number of neurons from 380k to 400k

[5bea1df380]: Removes deprecated messages and types from governance.proto along with related functions.

Proposal 135207 – LaCosta | CodeGov

Vote: ADOPT

Registry Canister

Reason:
Build successful and hashes match, commits look great and match the description. Found no issues.

[5506c7c41e]: DUPLICATE

[5e85addd44]: Removes all uses and references to ecdsa_config and replacing the names of functions whenever needed with chain_key_config.

[0206830a65]: Removes all use of the legacy ECDSA config to using ChainKeyConfig.

[b803bf020c]: Removes obsolete legacy ECDSA config.

[30b3069b8c]: DUPLICATE

[ec6e895aef]: Use MEMORY_MANAGER API from ic_stable_structures instead of dfn_core stable memory calls. Replaces the logic in the canister_pre_upgrade and canister_post_upgrade to use methods from this new API.

[ae3ab5aa3c]: Replaces references to ic-sns-governance with ic-sns-governance-api and moves request implementations for canisters to their own requests.rs files in rs/nervous_system/agent.

[6d4ecc89e1]: The node_reward_typefiled is currently accepted when registring new nodes but older nodes don’t have this filed set. This is a one time code that uses the map MISSING_NODE_TYPES_MAP to map each node to it’s reward type in the function add_missing_node_types_to_nodes.

[5c68a63660]: Creates a new module management_canister which holds the logic for request types and some helper functions for the ic-nervous-system-agent.

[69748856b6]: Adds a new structure RemoveNodeOperatorsPayload of requests to remove Node Operators that has a new field node_operator_principals_to_remove that will replace node_operators_to_remove ( still present for backwards compatibility) that outputs the Node Operators as principals instead of Vec[u8]

[f569791cc7]: Updates CHANGELOG entries.

About CodeGov…

CodeGov has a team of developers who review and vote independently on the following proposal topics: IC-OS Version Election, Protocol Canister Management, Subnet Management, Node Admin, and Participant Management. The CodeGov NNS known neuron is configured to follow our reviewers on these topics and Synapse on most other topics. We strive to be a credible and reliable Followee option that votes on every proposal and every proposal topic in the NNS. We also support decentralization of SNS projects such as WaterNeuron and KongSwap with a known neuron and credible Followees.

Learn more about CodeGov and its mission at codegov.org.