Proposal 136693 | Tim - CodeGov
Vote: Adopt
Reason: Build is successful, hashes match, commits match descriptions and the reasoning behind the changes is sound.
[8ac2131be1]
Adds new component check_canisters_are_all_protocol_canisters to upgrade_canisters_with_golden_nns_state test in order to check for new canisters that may need to be added.
[afef856bf5]
Adds field topic to type ProposalData, now called in ProposalData::is_manage_neuron(), and other changes as outlined in the commit notes in order to persist the proposal topic assigned at creation through the proposal lifecycle.
[c605cfaa17]
Removes NnsFunction::IcpXdrConversionRate from Governance::validate_execute_nns_function and adds it to NnsFunction::check_obsolete (to return an error) and removes other code related to the now obsolete exchange rate proposal topic.
[ba488dcedd]
Adds constant MIN_PARTICIPANT_ICP_LOWER_BOUND_E8S, set to 1 million, so as to enforce a lower bound on the amount of ICP that can be directly contributed to an SNS decentralisation swap.
[830f4caa90]
Removes direct dependency on ic-cdk-macros as these macros are now re-exported by ic-cdk.
[2949c97ba3]
Reverts commit 3490ef2a0, which updated the monorepo version of ic-cdk to 0.18.0 and maintained a distinction between ic-cdk 0.17.1 and ic-cdk 0.18.0 (and similarly for related crates).
[6970f48073]
Removes fields compute_allocation and memory_allocation from type ChangeCanisterRequest along with related function changes so as to prevent changing these allocations when installing code.
[0e5bc0d1a1]
Adds proposal field to ProposalData in set_up and distribute_rewards_with_stable_neurons benchmark functions in preparation for a future PR affecting the use of the ProposalData::topic field.
[abd1b51fcb]
Moves several tests from rs/nns/governance/tests/governance.rs to a new file rs/nns/governance/src/governance/tests/list_proposals.rs. Removes test_cascade_following_new.
[7e787c9c4b]
Moves current release notes from unreleased to released changelogs.
[d1dc4c2dc8]
Updates Rust version to 1.86.0.
[2d6efd6adf]
Minor refactoring in Governance::register_vote method without a change in behaviour, and expansion of dcoumentation for this method and for const NEURON_MINIMUM_DISSOLVE_DELAY_TO_VOTE_SECONDS_BOUNDS.
[b7ee0aa2e9]
Sets IS_DISBURSE_MATURITY_ENABLED to true in order to enable NNS maturity disbursement as outlined in this thread.
[f68a58fab6]
Updates Rust version to 1.85.1 + refactoring changes.
Proposal 136694 | Tim - CodeGov
Vote: Adopt
Reason: Build is successful, hashes match, commits match descriptions and the reasoning behind the changes is sound.
[3490ef2a07]
Updates the monorepo version of ic-cdk to 0.18.0 and maintains a distinction between ic-cdk 0.17.1 and ic-cdk 0.18.0 (and similarly for related crates).
[2c6673bdc9]
Switches several registry storage and value types to correpsonding high capacity types. This is part of a move towards handling larger messages as outlined in this thread, which will be required for the vetKeys feature.
[632e8943fb]
Updates to changelogs.
Proposal 136695 | Tim - CodeGov
Vote: Adopt
Reason: Build is successful, hashes match, commits match descriptions and the reasoning behind the changes is sound.
[3d869a114c]
Adds method are_node_rewards_enabled and uses it in conjunction with node_reward_type within Registry::do_add_node_ to ensure that an error is returned if nodes rewards are enabled but not reward type is not specified.
x 2949c97ba3 chore: Revert ic-cdk to 0.17.2 (#5139)
[4b0953166f]
Extends various tests to include vetKeys master key alongside previously added encryption keys.
[7e787c9c4b]
Moves current release notes from unreleased to released changelogs.
[1ac82d1c1d]
Adds test test_update_registry_local_store_handles_chunked_records along with associated code as per description.
[148f7ec3f8]
Moves get_chunk_with_validation from rs/registry/nns_data_provider/src/certification.rs to rs/registry/transport/src/high_capacity.rs along with further changes as outlined in the commit notes.
[811858594e]
Adds tests (and a supporting function) to cover vetKeys derivation cases.
Proposal 136696 | Tim - CodeGov
Vote: Adopt
Reason: Build is successful, hashes match, commits match descriptions and the reasoning behind the changes is sound.
[f9c905d29c]
Adapts the cycles-minting canister to use the external ic-cdk crate. Adds internal functions mint_cycles, caller, call_protobuf and now_system_time to replace functions from dfn_core. Other related code changes.
[665c75015a]
Removes the now redundant flag IS_AUTOMATIC_REFUND_ENABLED and adapts related code accordingly.
[b215232f64]
Corrects http://dashboard.internetcomputer.org/proposals/... to http://dashboard.internetcomputer.org/proposal/... within changelogs.
[882e7af8e9]
Renames getrandom_for_wasm to ic-dummy-getrandom-for-wasm and moves it from rs/crypto/ to packages/ so that it can be published on crates.io.
[4c20acbce9]
Updates to changelogs.]
About CodeGov
CodeGov has a team of developers who review and vote independently on the following proposal topics: IC-OS Version Election, Protocol Canister Management, Subnet Management, API Boundary Node Management, Node Admin, and Participant Management. The CodeGov NNS known neuron is configured to follow our reviewers on these technical topics. We also have a group of Followees who vote independently on the Governance and the SNS & Neurons’ Fund topics. We strive to be a credible and reliable Followee option that votes on every proposal and every proposal topic in the NNS. We also support decentralisation of SNS projects such as WaterNeuron, KongSwap, and Alice with a known neuron and credible Followees.
Learn more about CodeGov and its mission at codegov.org.