SNS calling functions

skilesare · March 6, 2023, 5:33pm

Can an SNS instance vote to call any function on the IC through governance? Or would it have to vote to deploy a wasm that calls a function?

mraszyk · March 9, 2023, 2:43pm

You can find more information on executing functions with SNS governance being the caller here (Section 7). Note that SNS governance can actually execute functions on any canister (even those that are not registered with SNS) except for the following ones: SNS governance, SNS root, SNS ledger, SNS swap, NNS ledger, and IC management canister.

infu · January 28, 2024, 1:16pm

Greetings @mraszyk
Just adding to the reply after checking out the SNS code. Please let me know if there are flaws in these statements:

The reserved canisters are here: ic/rs/sns/governance/src/governance.rs at 58e5a889ef576e27217e35849eb82a3bc172d7ff · dfinity/ic · GitHub

To clarify this means not all SNSes, just the ones where proposals get executed. One SNS calling canisters of another is allowed. Also, not all NNS ledgers are reserved (ckBTC, ckETH), only the ICP ledger.

Once and if SNSes get ckBTC and ckETH treasuries their canisters will be reserved too.
Meanwhile, we can create generic nervous functions that allow the DAO to use other ledgers.
Currently, an SNS treasury ICP account is {owner: governance_canister, subaccount:null}, and other treasuries will follow the same pattern.

infu · January 28, 2024, 3:33pm

Made a repo with for our external canister validator functions:

github.com

Neutrinomic/external_gf_validators/blob/336eafef25a1428032ab8754375e96f004f61d8d/src/main.mo#L15


      
          
          
          actor {
          
              type ValidationResult = {
                  #Ok: Text;
                  #Err :Text;
              };
          
          
              public query func validate_icrc1_transfer(req: Ledger.TransferArg) : async ValidationResult {
                  if (not Option.isNull(req.created_at_time)) return #Err("created_at_time must be null, the window is 24hours while proposals may take days");
                  
                  ignore do ? { if (req.memo!.size() > 200) return #Err("memo must be less than 200 bytes"); };
                  ignore do ? { if (req.to.subaccount!.size() > 32) return #Err("subaccount must be less than 32 bytes"); };
                  ignore do ? { if (req.from_subaccount!.size() > 32) return #Err("from_subaccount must be less than 32 bytes"); };
          
                  if (req.amount <= 0 or req.amount >= 10**50) return #Err("amount must be between 0 and 10^50");
                  ignore do ? { if (req.fee! > 10**50) return #Err("fee must be less than 10^50"); };
          
                  let msg:Text = "

Outputs:
amount: 1_000_000_000_000_000_000_000_000_000_000
to owner: lovjp-a2s3z-lqgmk-epyel-hshnr-ksdzf-abimc-f7dpu-33z4u-2vbkf-uae
to subaccount: ?“\AA\AA\AA\AA\AA\AA\AA\AA\AA\AA\AA\AA\AA”
from_subaccount: null
fee: ?10_000
memo: ?“\AB\AB\AB\AB\AB\AB”

Doesn’t use external libraries (only mo:base) so the security won’t be reduced. Also prevents these proposals to be used for inscribing large files

Topic		Replies	Views
SNS AddGenericNervousSystemFunction targeting SNS ledger forbidden Developers	3	118	June 27, 2024
Guidance on how to mint new tokens via SNS proposal Governance sns	6	1098	October 31, 2023
SNS Generic Nervous System Function Restrictions Developers Governance , sns	31	381	November 8, 2024
Issue: Asset Canister Can't Be Upgraded via SNS proposal Developers Discussing	11	516	April 4, 2024
Handing over dapp canisters to an SNS DAO Developers sns , DAO , asset-canister	0	350	October 18, 2023

SNS calling functions

Related topics