Escrow code - motoko

Developers Motoko
1

Here is the English translation of your post, cleaned up for technical clarity while keeping your original meaning and code:

Referring to the asynchronous nature of programming on ICP, I wanted to ask for your opinion:

Is it an optimal solution to treat the main recipient with the highest priority by removing the final recipient’s wallet from the map/table before the first funds are transferred?

Theoretically, if by any chance anything is left in the wallet, the recovery function will allow the escrow beneficiary to recover the missing funds.

The code was written to execute as few instructions as possible so it doesn’t waste instruction limits on the loop for the sylli drop, because I know that the amount for the beneficiary will most often be the largest and it needs to be treated with the highest priority.

Motoko

let pienioszki = await Icp.getBalance(Principal.fromActor(Self), escrow_work.wallet_id);
let ?target_profile  = Map.get(users, Principal.compare, escrow_work.start) else {return "sus error";};
let ?midle_profile  = Map.get(users, Principal.compare, escrow_work.middle) else {return "sus error";};
let target_wallet = target_profile.wallet;
let midle_wallet = midle_profile.wallet;
ICP_FEE := await icpLedger.icrc1_fee();

//delate escrow anty-multicall backdor

ignore Map.delete(escrows, Nat.compare, escrow_id);
if(escrow_work.middle_drop > ICP_FEE){
  ignore await Icp.transfer( escrow_work.wallet_id, midle_wallet, escrow_work.middle_drop, ICP_FEE);
};
if(escrow_work.sylli_drop > ICP_FEE){
  ignore await Icp.transfer( escrow_work.wallet_id, sylli_wallet, escrow_work.sylli_drop, ICP_FEE);
};

//make recovery wallet target
ignore Map.add(recover, escrow_work.wallet_id, target_wallet);

// loop to say ICP to target_escrow
loop {
  try {
    let pienioszki = await Icp.getBalance(Principal.fromActor(Self), escrow_work.wallet_id);
    let result = await Icp.transfer( escrow_work.wallet_id, target_wallet, pienioszki, ICP_FEE);
    switch (result) {
      case (#Ok(_) or #Err(#Duplicate(_))) { break };
      case (#Err(_)) {};
    };
  } catch (_) {};
};

// clean all info escrow 

ignore Map.delete(users, Principal.compare, escrow_work.start);
ignore Map.delete(users, Principal.compare, escrow_work.middle);
ignore Map.delete(users, Principal.compare, escrow_work.end);
ignore Map.delete(escrows, Nat.compare, escrow_id);
return "ICP has been refunded.";