kk…So if rEnd > rSize { rEnd = rSize -1}?
Yes, exactly.
I think it makes sense, but is a pretty big change since files were ‘just requested’ before without any byte specification. It is actually much simpler but we need some time to refactor the code.
1 Like
We are rolling back within the next hour or two. The rollout just takes a moment. Then, you are back on the old behavior for all certified endpoints.
Do you also use raw?
Yes…we use raw in a number of places. Would it be possible to have nginx branch and only use the chunk request method if a range request is present in the initial request, but the classic behavior otherwise(in the mean time)?
We can roll it back completely and then enable it again only on raw. It’s not great for @lastmjs, but we know it works and will enable it again asap.
So it will be enabled on raw again ASAP?
I’m not sure I followed all of that, but if it will work on raw again that will be great. I would love to discuss how to get certification to work eventually with range requests.
I’m also curious why nginx is set to request 1 MB chunks. Canisters can return up to 3 MB in one message response, was it determined that 1 MB is optimal? And what would happen if a canister returned less than 1 MB?
It’s a little strange that the canister can’t actually control the ranges returned…since nginx always requests 1 MB. I wonder if this will cause problems/confusion for developers.
None of our files are certified at this point so everything goes through raw. (We have some cert code but it isn’t enabled yet as we v2 was coming and we knew @tomijaga was working on it for motoko)
Sorry @lastmjs, it’s bad news for you for the moment:
We are disabling it again everywhere to give @skilesare and team some time to roll out the fix to their canisters. Once that is done, we will enable it again.
For now, we can have a single boundary node that is not part of the loadbalancer running with the range requests enabled such that you guys can test.
1 Like
Good luck, I appreciate all of the work put in to make this work, the reception has been great
1 Like
We have completed the rollback. Everything should work again as before.
1 Like