We are happy to announce that voting is now open for a new IC release and the retirement of old replica versions 43c85184884cf0a23ecee4c28177b359579d0fea and d353989b94e5862692ea2887637dcacace4e244c.
The NNS proposal is here: IC NNS Proposal 124857 .
Here is a summary of the changes since the last release:
[28b8773cb] Crypto: perf: add crypto basic sig benchmarks with remote vault
[be6ab0121] Crypto: refactor: Use RustCrypto for all hashing
The two SHA256 sums printed above from a) the downloaded CDN image and b) the locally built image, must be identical, and must match the SHA256 from the payload of the NNS proposal.
At the time of this comment on the forum there are still 2 days left in the voting period, which means there is still plenty of time for others to review the proposal and vote independently.
We had several very good reviews of the Release Notes on these proposals by @Zane, @cyberowl, @ZackDS, @massimoalbarello, and @ilbert. The IC-OS Verification was also performed by @Gekctek and @tiago89. I recommend folks talk a look and see the excellent work that was performed on these reviews by the entire CodeGov team. Feel free to comment here if you have any questions or suggestions.
Hey @sat would you please let the change owners for 124857 know that @cyberowl had a few comments and questions about some of the details in commits [09d6aa3d4], [660899bd2], and [56800b234] that they might want to review. He provided more details in his review posted in the CodeGov portal in DSCVR. Here are the relevant screen shots…
Thanks for catching some of the typos, indeed these were missed.
The change to principal id was made because with the introduction of the new endpoint (/api/v2/subnet/) we have cases where the id passed in such api calls to the replica does not always represent a canister anymore. So, the switch was made to principal id and wherever it’s applicable we additionally check whether this is really supposed to be a canister id to proceed with further processing (e.g. in query or update calls or the existing canister state read but for example not in the new one). In hindsight, it should have probably been mentioned as I realise now that it might not have been super clear without more context.
The last part around the message for the two condition is something that was simply moved around in the commit, so kept the message intact. I can bring it up with the code owners to make a change if they agree.