Proposal 134339
Vote: ADOPT
Reason:
Build successful and hashes match. Would have preferred if there was an explanation on how to verify the proposal like all other proposals from the PCM topic for easy use by beginners.
Review:
Includes commits reviewed previously which I will leave below for easy access. Since the proposal didn’t leave a way to check the commits affecting the rs/ledger_suite/icrc1/index-ng directory to compare the changes, the prompt git log -- rs/ledger_suite/icrc1/index-ng can be used with this purpose.
[2b2123622]: Renames several heap and stable memory related metrics in order to use a general alert for canisters that export the same metrics under the same name. e.g archive_node_stable_memory_bytes is renamed to stable_memory_bytes removing the archive_ prefix to make it general.
[ee1006503]: Adds the test should_sync_according_to_interval to verify that the ICRC index-ng is synced with the ledger after sending a transaction and waiting for a specified interval or a default one.
[15d752c5d]: Removes the use of reexports (meaning the module imports from another module and then makes them available from within reexporting) of types and functions from ic_state_machine_tests in preparation for StateMachine test migration to PocketIC.
[d361dd692]: Changes the base message execution fee and the per instruction cycle fee in response to increased demand on ICP. The following thread was used for the discussions on this topic.
[07cf5773d]: Previously if there was an attempt to upgrade the ICRC index-ng canister from a version with u64 tokens to one with u256 tokens or vice versa it would cause the canister to be unusable until it was upgraded with a fix since the failure would only be caught after the post-upgrade. The fix adds a check in post-upgrade causing the upgrade to fail if there is an attempt at this upgrade. Tests were also included.
[03dd6ee6d]: Renames the ircr1 state machine tests from ic_icrc1_ledger_sm_tests to ic_ledger_suite_state_machine_tests.
[fcbc91f0a]: Updates the version of ic-cdk from 0.13.5 to 0.16.0.
[4eca90d6e]: Creates new subdirectories within rs/rosetta/ and moves code accordingly.
[3bbabefb7]: Adds a new directory rs/ledger_suite/ and moves ICP and ICRC1 ledger suites from rs/rosetta-api/ into their respective subdirectories within the new directory.