Retired: ICDevs.org Bounty 0 - React-Native Agent

jzxchiang · November 25, 2021, 11:33pm

This is his profile: Kudo (Kudo Chien) · GitHub

skilesare · January 6, 2022, 5:30pm

We’ve accelerated this bounty with 10 more ICP from the DFINITY Acceleration Grant.

We are going to set aside 5 ICP for the dec that added the wasm stuff to the android build. This is now a 26 ICP bounty for basically setting up some config files. If you want to get involved in building for the IC, this is a great spot to do it!

Ashley · January 18, 2022, 7:04am

Thank you to the moon and back. This unblocked me after months. I’m the founder of DSocial, we are YouTube on the IC.

Mobile app is back in development now Thank you!

Ashley · April 28, 2022, 1:46pm

Working on iOS but not Android: GitHub - decentralised-social/expo-rn-dfinity-icp-example: Example React Native (in Expo) using ICP

skilesare · April 28, 2022, 2:05pm

Expo (React Native) JS Engine when running in Debug

Shake phone, and tap Debug Remote JS, you’ll notice the app now works on Android. This is because the JS Engine on Android in Debug mode supports BigInt

But that means normal mode and native builds do not #FunTimes

This is amazing

I wonder why a polyfill does not work?

Ashley · April 28, 2022, 2:23pm

LOL

Basically the * / ** === & | etc etc ops, don’t work reliably via the polyfill. These seem to give unexpected results and as such the while loops runs forever.

This only happens is the typeof of a bigint is object, thus not native support. If typeof is bigint it works.

iOS device/simulator: debugger on/off: bigint
Android simulator/device, debugger on: bigint
Android simulator/device, debugger off: object

kpeacock · September 7, 2022, 6:55pm

@dpdp - did you pull the bls verification code that you’re patching in from an existing package, or did you write it yourself? If it is from Origyn, do we have your permission to add it to agent-js? I’ve just merged support to polyfill BLS verification without patching feat: support for bls verification polyfill by krpeacock · Pull Request #626 · dfinity/agent-js · GitHub, and I’d like to make this process simple by shipping the polyfill as an additional package on NPM as @dfinity/bls-verify, so that we don’t have to ask people to copy a large file around

kpeacock · September 7, 2022, 9:28pm

Oh wait, I see that it was auto-generated from the wasm

dpdp · September 8, 2022, 6:52am

@kuchmenko did work on this and can explain a bit more; I think we just converted the wasm to js; but there is some caveats;

@kuchmenko mentioned Plug has another solution which is to run the Rust code via FFI;

domwoe · September 8, 2022, 9:28am

Do you have a link to the code? I just had a look and couldn’t find anything in the Plug repo.

dpdp · September 8, 2022, 9:31am

Ha it seems they just use the whole agent-rs via ffi… plug-mobile/rust/.cargo/mobile_app at develop · Psychedelic/plug-mobile · GitHub

domwoe · September 8, 2022, 9:46am

Thanks! Wrong repo

Seems only the verify function is exposed though, but I can’t find a place where it’s actually called.

dpdp · September 8, 2022, 10:08am

github.com

Psychedelic/plug-mobile/blob/develop/customPatches/ios/@dfinity+agent+0.9.3.patch#L75


      
          -        const res = await bls_1.blsVerify(key, sig, msg);
          -        this.verified = res;
          -        return res;
          +    async verify(requestId) {
          +        // const rootHash = await reconstruct(this.cert.tree);
          +        // const derKey = await this._checkDelegation(this.cert.delegation);
          +        // const sig = this.cert.signature;
          +        // const key = extractDER(derKey);
          +        // const msg = buffer_1.Buffer.concat([domain_sep('ic-state-root'), rootHash]);
          +        // const res = await bls_1.blsVerify(key, sig, msg);
          +        // Do BLS validation directly on ic-agent on the rust side
          +        const payload = JSON.stringify({ request_id: Array.from(requestId), cert: parseArrayBuffers(this.cert) })
          +        const responseString = await SigningBridge.signData(payload);
          +        const response = JSON.parse(responseString);
          +        const status = parseResponseStatus(response);
          +        this.verified = status;
          +        return status;
               }
               checkState() {
                   if (!this.verified) {
          diff --git a/node_modules/@dfinity/agent/lib/cjs/polling/index.js b/node_modules/@dfinity/agent/lib/cjs/polling/index.js

github.com

Psychedelic/plug-mobile/blob/develop/customPatches/android/@dfinity+agent+0.9.3.patch#L79


      
          +        // const rootHash = await reconstruct(this.cert.tree);
          +        // const derKey = await this._checkDelegation(this.cert.delegation);
          +        // const sig = this.cert.signature;
          +        // const key = extractDER(derKey);
          +        // const msg = buffer_1.Buffer.concat([domain_sep('ic-state-root'), rootHash]);
          +        // const res = await bls_1.blsVerify(key, sig, msg);
          +        // Do BLS validation directly on ic-agent on the rust side
          +        /* This is the code that is used to verify the certificate. */
          +        
          +        const payload = JSON.stringify({ request_id: Array.from(requestId), cert: parseArrayBuffers(this.cert) });
          +        const blsResponse = await BLSModule.androidVerifyJson(payload);
          +        const response = JSON.parse(blsResponse);
          +        const status = parseResponseStatus(response);
          +        this.verified = status;
          +        return status;
               }
               checkState() {
                   if (!this.verified) {
          diff --git a/node_modules/@dfinity/agent/lib/cjs/polling/index.js b/node_modules/@dfinity/agent/lib/cjs/polling/index.js
          index 39c803a..aef14a3 100644
          --- a/node_modules/@dfinity/agent/lib/cjs/polling/index.js

jzxchiang · September 8, 2022, 10:12am

FWIW I also went down the Rust FFI route. It works and is really fast, but it requires a lot of platform-specific setup and code, which makes it less like a library and more like a framework.

domwoe · September 8, 2022, 10:19am

Thanks. I saw this as well, but I still don’t understand how this is actually getting called.

Update: Ah, it patches agent-js to use the verify function form agent-rs/ic-agent via FFI

kpeacock · September 8, 2022, 4:32pm

At the very least, going forward you’ll be able to pass a blsVerify option to an Actor and polyfill it however you choose without needing to patch node_modules. I’m also going to provide a pure JS package for it, but it is very slow. I’ll see if I can optimize it by stripping out overhead in the miracl implementation

adrian-d-hidalgo · March 14, 2024, 8:59pm

I don’t know if this discussion is still open, but here I have my solution for this:

GitHub - bundlydev/motoko-nextjs-react-native.

kpeacock · June 10, 2024, 8:45pm

I still have to publish official docs, but this is my MVP example using Expo GitHub - krpeacock/ic-expo-counter: very basic counter example for a react native IC app

There’s no more need for a dedicated React Native agent now that we’ve removed the wasm import for bls verification

Topic		Replies	Views
Update to ICDevs Bounty Program Education community-consideration	3	1171	February 15, 2022
Awarded: ICDevs.org Bounty #50 - Customer Service updates for candidUI Bounties Discussing	4	656	June 23, 2023
Awarded: ICDevs.org Bounty 1 - Basic Tutorial and Site Bounties	31	3232	May 14, 2022
Open: ICDevs.org Bounty #7 - Bug Bounty Bounties Discussing , community-consideration	0	814	January 6, 2022
Complete: ICDevs.org - Bounty #9 - Cover Browser Plugin Bounties Discussing	25	2139	April 18, 2022

Retired: ICDevs.org Bounty 0 - React-Native Agent

Related topics