Proposal 135931 | Tim - CodeGov
Vote: Adopt
Reason: Build is successful, hashes match, commits match descriptions and the reasoning behind the changes is sound. I’ve reviewed commits for Consensus, Interface and Owners as detailed below.
Review
Features:
[9d4e0c4c9]
Allows best-effort calls to be made to and from all application subnets (but not system subnets) rather than just the 3 subnets for which this was initially made available.
[51b1dfde0]
Adapts get_master_public_keys function in orchestrator to use get_vetkey_public_keys to return public keys + logging if the catch-up package payload.as_idkg() is empty, rather than just returning an empty BTreeMap.
[2fe8aefaf]
Adds NodeRewardsCanister::get_registry_value API method. Sets an interval of 1 hour for the node rewards canister to sync registry data. Other changes consistent with the description.
Bugfixes:
[41868ddc7]
Adapts test to check that blocks are returned in BFS order to prevent erroneous test results, as explained in the commit notes.
Chores:
[a6cbcf713]
Removes impl ExhaustiveSet for AlgorithmId as per description.
[1e5e864a9]
Increases download timeout for create_hostos_upgrade_file to 2 minutes.
[fa37ed573]
Upgrades ic_bls12_381 to version 0.10.1 and itertools to version 0.13.0.
Refactoring:
[4ba1e1b7b]
Changes derivation_path field in SignWithThresholdContext and input field of VetKdArguments to utilise an Arc so as to reduce the need for cloning.
[bd2d7d1fa] [ec7834c47]
Changes panic! to debug_assert! in Xnet payload take_prefix method and removes the last message if this is used. The second commit adapts the method to return an empty slice instead of panicking if self.messages.as_ref() is None.
Tests:
[54c19b3b6]
Adds LocalStoreImpl::from_changelog method to create a LocalStore from a Changelog. Adds write_protobuf_simple and write_to_file_simple functions to serialise protobuf messages and write these to file with improved efficiency.
About CodeGov
CodeGov has a team of developers who review and vote independently on the following proposal topics: IC-OS Version Election, Protocol Canister Management, Subnet Management, Node Admin, and Participant Management. The CodeGov NNS known neuron is configured to follow our reviewers on these technical topics. We also have a group of Followees who vote independently on the Governance and the SNS & Neurons’ Fund topics. We strive to be a credible and reliable Followee option that votes on every proposal and every proposal topic in the NNS. We also support decentralisation of SNS projects such as WaterNeuron, KongSwap, and Alice with a known neuron and credible Followees.
Learn more about CodeGov and its mission at codegov.org.