Proposal 135051 | Tim - CodeGov
Vote: Adopt
Reason: Build is successful, hashes match, commits match descriptions and the reasoning behind the changes is sound. I’ve selectively reviewed Crypto and Node commits along other commits so as to maximise team coverage.
Review
Features:
[2da213890]
Adds registry_version to TranscriptData and stores this in lockable_threshold_sig_data_store as per the description.
[dd37e7009]
Various changes to the VetKD API and tests. Main changes include removal of the TransportSecretKey type and methods (generate, decrypt, etc), changes to some error types, and spitting of the function to combine encrypted key shares into an encrypted key into 3 variations: combine_unchecked, combine_all and combine_valid_shares.
[c05b185fe]
Adds detailed log messages for success or failure of GuestOS start up.
Bugfixes:
[623b155ca]
Adds logic to create a SOCKS proxy client for https outcall requests on API boundary nodes and to compare the results of using this on old boundary nodes with results coming through the new API boundary nodes.
[3b2afad38]
Slight change to onboarding log message to add clarity.
[33941442d]
Changes the http query call error message so as to show the error code just once instead of twice.
Performance improvements:
[fb75bf40f]
Changes Python-generated script for generating the file system image such that this is now generated by mkfs.ext4.
Chores:
[3f14a0806]
Moves cli module, as per description.
[155bd42f4]
Adds dfx-core as a dependency, as well as adding or updating several other dependencies, and then uses it in the SNS CLI as per description.
[967fe2118]
Upgrades version for bitcoin crate and related crates + associated code changes.
[0b1d6e41d]
Changes to several service files, mostly changing Requires to Wants and logging changes.
[0626768a9]
Matches description.
[cf52a5011]
Deletes the retry-ipv6-config service from boundary-guestos.
[f3a8e93df]
Updates Boundary GuestOS, GuestOS, HostOS and SetupOS base image container references.
Refactoring:
[ae3ab5aa3]
Moves Request implementations from various NNS canister crates into rs/nervous_system/agent.
[fcc88deb5]
Matches description.
Tests:
[1ef59e5f3]
Removes wait_until_ready_for_interaction logging synchronisation from support_snses and recover_nns_subnet tests.
[ca3b684a4]
Changes to “random traffic” tests of calls and replies as per description, along with new tests in rs/messaging/tests/memory_tests.rs.
Proposal 135052
Vote: Adopt
Reason: Build is successful and hashes match. The proposal consists of a single commit which re-enables the hashes-in-blocks feature by setting the HASHES_IN_BLOCKS_FEATURE_ENABLED flag to true.
About CodeGov…
CodeGov has a team of developers who review and vote independently on the following proposal topics: IC-OS Version Election, Protocol Canister Management, Subnet Management, Node Admin, and Participant Management. The CodeGov NNS known neuron is configured to follow our reviewers on these topics and Synapse on most other topics. We strive to be a credible and reliable Followee option that votes on every proposal and every proposal topic in the NNS. We also support decentralisation of SNS projects such as WaterNeuron and KongSwap with a known neuron and credible Followees.
Learn more about CodeGov and its mission at codegov.org.