Proposal Reviews | Tim - CodeGov
Proposal 134966
Vote: Adopt
Reason: Build is successful, hashes match, commits match descriptions and the reasoning behind the changes is sound. I have selectively reviewed Consensus, Interface and Node commits as detailed below.
Review
Features:
[14ba37e5c)]
Adds new types VetKdPayload, InvalidVetKdPayloadReason, VetKdPayloadValidationFailure, VetKdErrorCode and VetKdAgreement along with further changes as per the description.
[de11e7933]
Adds new methods do_replace_node_with_another and make_remove_or_replace_node_mutations in order to allow direct replacement of a node in subnet. Changes do_add_node_ to check for and remove multiple nodes with the same IP address as the new node.
[6b3c8440e]
Adds submit_proposal and manage_neuron methods to rs/nervous_system/agent/. Also adds PocketIcAgent type in order to allow sender to be specified.
[51f818e45]
Adds new script to SetupOS scripts to set the hardware clock to UTC and check that the system clock is synchronised.
Bugfixes:
[6d3c48889]
Adds new type SignedIngressId containing both message ID and hash, to replace most instances of IngressMessageId in order to ensure that the messages identified are unique. This is part of the hashes-in-blocks implementation.
[8df6997dd]
Replaces previously removed ic-admin subcommands in ic-recovery in order to fix test failures.
[be8de1981]
Alters the ledger_version field of Ledger in the ICRC1 ledger such that it no longer defaults to the current version specified by the LEDGER_VERSION const, as per explanation in commit notes.
[ac71086bf]
Changes nns_url in development modes from wiki.internetcomputer.org to cloudflare.com/cdn-cgi/trace in order to solve a testing issue.
Chores:
[00f10afcf]
Adds new type AbortableBroadcastChannels in order to group together various pre-existing abortable broadcast channel types.
[f367c148b]
Adds type Bouncers in order to group together various pre-existing bouncer types + associated code changes.
[816f0edab]
Several changes to P2P processes including new type AbortableBroadcastChannelManager, changes to the implementation of AbortableBroadcastChannelBuilder, StateSyncManager and setup_consensus_and_p2p.
[fc2787097]
Upgrades Rust version to 1.84 and rules_rust to 0.56.0. @dsharifi Due to the large number of changes in this commit it was not possible to view the full set of changes in GitHub, including any of the Rust code changes.
[eb9afbb50]
Adds more detail to some error messages for the state-tool copy command.
[550209a75]
Removes now redundant deploy-updated-ssh-account-keys script.
[0126ae64c]
Updates base container image references for GuestOS, HostOS, SetupOS and Boundary Node GuestOS.
Refactoring:
[834bead31]
Changes to transcript management in preparation for VetKD implementation, as per the detailed and very helpful description in the commit notes. @Sawchord @eichhorl
[6b09303da]
Serialises transcripts directly into pb::NiDkgTranscript instead of using pb::TaggedNiDkgTranscript. Corrects the make_nodes_registry state machine test as per the description.
[a4dd63884]
Renames setup-ssh-account-keys and setup-ssh-keys services.
Proposal 134967
Vote: Adopt
Reason: Build is successful and hashes match. The proposal consists of a single commit which re-enables the hashes-in-blocks feature by setting the HASHES_IN_BLOCKS_FEATURE_ENABLED flag to true.
About CodeGov…
CodeGov has a team of developers who review and vote independently on the following proposal topics: IC-OS Version Election, Protocol Canister Management, Subnet Management, Node Admin, and Participant Management. The CodeGov NNS known neuron is configured to follow our reviewers on these topics and Synapse on most other topics. We strive to be a credible and reliable Followee option that votes on every proposal and every proposal topic in the NNS. We also support decentralisation of SNS projects such as WaterNeuron and KongSwap with a known neuron and credible Followees.
Learn more about CodeGov and its mission at codegov.org.