Thanks @Luka! Looks like there’s a good chance that logic is the issue. I raised questions about that specific line a few weeks ago
(EXCLUDED_TEAMS
has since been renamed to NON_REPLICA_TEAMS
)
The master branch would describe the reality of the situation. Isn’t that better? There are already non-linearities in the deployment history. Can I ask what problems representing this on the master branch would cause? (at least in cases where there’s genuinely no divergence)
This sounds promising, except that release notes will intentionally (as opposed to accidentally) exclude commits that modify GuestOS. Why would DFINITY want to do this? In some ways this could be seen as worse. It certainly seems like a bad precedent to set for such critical proposals. I think the principle here is the most important thing (which is why I’ll reject this proposal, in peaceful protest of the obscured changes - I suspect there are more).
Thanks Luka. Do you have any thoughts about the deployment target commit message convention that we discussed with @sat last week in our CodeGov meeting. My impression was that this was being investigated.