Proposal 134988: Upgrade the Governance Canister

Approve Proposal 134988

Proposal

  • Canister id rrkah-fqaaa-aaaaa-aaaaq-cai is indeed the governance canister.
  • The upgrade args correspond to the empty args.
  • The install mode is indeed upgrade.
  • The wasm hash is reproducible.

Screenshot 2025-01-27 at 10.30.46

In-depth Review

  • Paging Implementation:

    • The code handles page_number and page_size with a cap at MAX_LIST_NEURONS_RESULTS (500). The total_pages_available computation is part of the response.
  • Periodic Confirmation:

    • Neurons not refreshed within specified periods see a reduction in voting influence and may stop following others.
  • InstallCode Hashes:

    • Hashes are now generated when proposals are created, ensuring consistency throughout the proposal’s lifecycle.
  • Minor Changes:

    • BUILD.bazel: Adjustments to visibility rules and the introduction of DID_FILES for better module management.

    • API Changes: New fields in ListNeurons and ListNeuronsResponse are reflected in proto files and the corresponding conversion functions in conversions.rs.

    • Performance: Benchmarks in canbench_results.yml reflect minor changes in instruction counts due to the new features.

2 Likes