Proposal 137582 | Tim - CodeGov
Vote: Adopt
Reason: This proposal upgrades the Governance canister. Commits match descriptions and the reasoning behind the changes is sound. Running the provided verification code returned a “403 Forbidden” error as shown in the image above, so I was unable to verify the wasm hashes. However, two other reviewers have so far verified the hashes so I have voted to adopt on this basis. Commits are reviewed below.
[447105bd1b]
Adds field memory_metrics (consisting of 8 metrics) to type CanisterStatusResult, which is returned by the canister_status update method of both the NNS and SNS root canisters.
[696d448ffa]
Adds method Governance::validate_add_or_remove_node_provider, serving to validate a proposal to add or remove a node provider with respect to the expected requirements (fields not missing, can’t add an already existing node provider, etc) and to ensure that the account identifier is 32 bytes long (so that it includes the checksum).
[2a2d6c212f]
Adapts VotingPowerSnapshots::previous_ballots_if_voting_power_spike_detected so that the check for voting power spikes will still happen (outside of tests) even if voting power snapshots are not yet full.
[4dc479127a]
Updates changelog files.
[f56ac62826]
Adds logic for the execution of the previously introduced new proposal type FulfillSubnetRentalRequest. This includes methods to check the features flag for enabling this proposal type (currently disabled), to verify that an appropriate rental request exists, to assemble the subnet payload and create the subnet itself, and to notify the subnet rental canister that this has been completed.
Proposal 137583
Vote: Adopt
Reason: This proposal upgrades the Cycles-Minting canister. Commits match descriptions and the reasoning behind the changes is sound. The same issue with verification occurred as for the previous proposal, but I note that other reviewers have performed the verification successfully. Commits are reviewed below.
[1c325081a0]
Changes StateV2::state_version to return StateVersion(2) instead of StateVersion(3) so as to align with the canister state version that is currently in use.
[1da26cc6ff]
Sets a specific monthly cycles minting limit for the subnet rental canister of 500 quadrillion, in contrast to the existing limit of 150 quadrillion cycles for other uses, and adds logic to check for an implement this distinction. (@msumme I was unaware that cycles had the same collective noun as pandas. I hope this catches on!) Also adds specifications for canister state StateV2 along with associated migration logic.
[016e8ed658]
Adds an environment_variables flag to indicate whether environment variables are supported. Adds environment_variables as a field to various canister-related types, implemented as a BTreeMap or vector of name-value pairs.
[d3649d8579]
Updates changelogs.
About CodeGov 
CodeGov has a team of developers who review and vote independently on the following proposal topics: IC-OS Version Election, Protocol Canister Management, Subnet Management, API Boundary API Boundary Node Management, Node Admin and Participant Management. The CodeGov NNS known neuron is configured to follow our reviewers on these technical topics. We also have a group of Followees who vote independently on the Governance and the SNS & Neurons' Fund topics. We strive to be a credible and reliable Followee option that votes on every proposal and every proposal topic in the NNS. We also support decentralisation of SNS projects such as WaterNeuron, KongSwap, and Alice with a known neuron and credible Followees.
Learn more about CodeGov and its mission at codegov.org.