Proposal 134441
Vote: ADOPT
Previously rejected the proposal not only due to lack of explanation in the forum but in the proposal aswell. This has improved in this proposal.
The proposal was previously adopted but it failed due to a bug that has received a fix in Proposal 134437. I have reviewed and adopted this proposal here, with the relevant information regarding the fix being:
The following line caused the problem if let Some(old_features) = subnet_record.features where if the old_features was None the condition would evaluate to false triggering the panic Proposal attempts to change sev_enabled for Subnet '{}', but sev_enabled can only be set during subnet creation. which isn’t true. Now this if condition is replaced with if let Some(sev_enabled) = features.sev_enabled that makes sure that only sev features are not changed since this can only be set during subnet creation.