Proposal to elect new release rc--2025-05-01_03-23

Governance NNS proposal discussions
,
8

Proposal 136436 | Yuvika - Zentih Code

Summary

  1. Vote: Adopt
  2. Hash: Hashes match
  3. Reasons to adopt: Builds fine + hashes match + release notes match the commits.

build-136436
build-136436720×390 107 KB

Commits

Features:

  • d511b6665
    Summary: Make CanisterModule writable for snapshot upload.
    Notes: Add a write method to CanisterModule, that can write and upload binary data in slices using the snapshot data upload endpoints.
    Review: The description matches the code changes.

  • b0cbc5c18
    Summary: Forbid setting fee collector to minting account.
    Notes: Implement a safety check in ledger initialization to prevent setting the fee collector account to the minting account.
    Review: The description matches the code changes.

  • 4011c442b
    Summary: Routing: Load wasms lazily.
    Notes: Reduce time spent in the critical path of checkpointing by implementing lazy loading for wasm files like pagemaps. Previously, it was a blocking call to switch_to_checkpoint, but this change will improve performance.
    Review: The description matches the code changes.

Bugfixes:

  • 36b6bb43b
    Summary: Remove journald rate limit and increase usable max space for journald logs.
    Notes: Update variables in journald.conf to SystemMaxUse=8G, RateLimitBurst=0, and RateLimitIntervalSec=0.
    Review: The description matches the code changes.

Chores:

  • d2547393b
    Summary: Bump ic-management-canister-types to v0.3.0.
    Notes: Upgrade ic-management-canister-types from v0.2.1 to v0.3.0.
    Review: The description matches the code changes.

  • b8ee431b0
    Summary: publish canlog and canlog_derive.
    Notes: Add canlog and canlog_derive crates in packages to be able to publish them on crates.io. And provide advanced logging features such as filtering/sorting etc. over the existing one ic-canister-log.
    Review: The description matches the code changes.

  • 69fa3a774
    Summary: Update Base Image Refs [2025-04-25-0148].
    Notes: Update the base image references used for IC OS.
    Review: The description matches the code changes.

  • 0e0d903fd
    Summary: Update Base Image Refs [2025-04-24-0808].
    Notes: Update the base image references used for IC OS.
    Review: The description matches the code changes.

Refactoring:

  • f23d875cd
    Summary: Move nns delegation fetching logic from lib.rs to nns_delegation_manager.rs.
    Notes: Refactor and move nns delegation fetching logic from lib.rs to another file nns_delegation_manager.rs
    Review: The description matches the code changes.

  • 9ba1a3bcb
    Summary: Move unflushed_changes out of snapshots.
    Notes: Refactor the concept snapshot operations to a more general concept of checkpoint operations, i.e. move unflushed_changes field from CanisterSnapshots to SystemMetadata::unflushed_checkpoint_op. There should be no behaviour change.
    Review: The description matches the code changes.

  • c2d568436
    Summary: update imports from ic_canisters_http_types to newly published ic_http_types crate.
    Notes: Rename rs/rust_canisters/http_types to packages/ic-http-types.
    Review: The description matches the code changes.

Tests:

  • a8f222a9d
    Summary: Add wasm types test bazel target and align WasmHash Display implementation with tests.
    Notes: Add rust_test, to Bazel build which is also called wasm_types_test. Update {:2x} to {:02x} in the Display implementation to format bytes.
    Review: The description matches the code changes.