Proposal 135301 | Tim - CodeGov
Vote: Adopt
Reason: Commits match descriptions and the reasoning behind the changes is sound. I was unable to reproduce the build successfully, as per the error that I’ve shown above, but have voted to adopt as other reviewers have managed to build the replica and verify that hashes match.
I’ve selectively reviewed Consensus, Crypto and Interface commits as detailed below.
Review
Features:
[df5828f5b]
Specifies the first 3 subnets for which best-effort calls will apply. Decreases SUBNET_GUARANTEED_RESPONSE_MESSAGE_MEMORY_CAPACITY from 25 GiB to 15 GiB.
[0ff90c220]
Changes to create local transcripts for Vetkeys. Adds functions vetkd_key_ids_for_subnet and tags_iter. Adds chain_key_initializations to CatchUpPackageContents within the returned values of insert_initial_dkg_transcript.
[09b5bac97]
Adds new directory with logic to implement the VetKd payload builder and validator, as described in detail in the commit notes.
[1eedff6ff]
Modifications to idkg/pre_signer.rs to use the endpoints from the new VetKdProtocol crypto implementation to create and verify encrypted key shares. Also re-specifies fake_master_public_key_ids_for_all_algorithms as fake_master_public_key_ids_for_all_idkg_algorithms for several tests.
[b24f181ad]
Changes const REGISTRY_SOCKS_PROXY_DARK_LAUNCH_PERCENTAGE from 0 to 10, so as to specify the probability of using API boundary node addresses for the SOCKS proxy dark launch at 10%, and adds metrics to track this.
[17e911e1f]
Adds rand feature to ic-ed25519 and makes it optional.
[39f6eec55]
Splits payload_size_bytes into request_payload_size_bytes, call_timeouts_seconds and response_payload_size_bytes in order to allow a mix of guaranteed response and best-effort calls in several XNet tests. Also version updates for various packages.
[6c5d1942f]
Renames sync_and_mark_files_readonly function to mark_files_readonly_and_sync and removes logging. Adds function promote_scratchpad_to_unverified_checkpoint and modifies function scratchpad_to_checkpoint to create an unverified marker in the scratchpad and to check that the scratchpad does indeed have an unverified marker before transitioning it to a checkpoint.
Bugfixes:
[f17589cf2]
Changes get_next_block_hash_to_sync in the bitcoin adaptor such that new blocks in the sync queue are prioritised over blocks in the retry queue, so as to avoid creating multiple forks.
[d2ec812ef]
Adapts get_successors in the bitcoin adaptor so that if the response is empty then all blocks in the cache are marked for pruning.
[c8436757c]
Adds port 22 to tcp_ports_for_node_whitelist.
Chores:
[8ee65b22e]
Removes TaggedNiDkgTranscript type as this is no longer needed.
[47b1aa1e2]
Changes ArtifactProcessor trait, run_artifact_processor function, Processor and IngressProcessor structs and respective new methods from public to private within rs/p2p/artifact_manager/src/lib.rs.
[5506c7c41]
Renames ic-management-canister-types to ic-management-canister-types-private. It was not possible to view the full set of changes as there were 322 files changed and GitHub was unable to display the changes in full.
[97bcf0945]
Moves ic-crypto-secp256k1 from rs/crypto/ to packages/ and renames it to ic-secp256k1
so it can be published on crates.io.
Refactoring:
[e8d8808a2]
Adds is_best_effort() flag for inter-canister requests.
Proposal 135302
Vote: Adopt
I was unable to reproduce the build successfully, as per the error that I’ve shown above, but have voted to adopt as other reviewers have managed to build the replica and verify that hashes match. The proposal consists of a single commit which reverts the roll out of best-effort calls to the first few subnets from commit df5828f, as reviewed above.
About CodeGov
CodeGov has a team of developers who review and vote independently on the following proposal topics: IC-OS Version Election, Protocol Canister Management, Subnet Management, Node Admin, and Participant Management. The CodeGov NNS known neuron is configured to follow our reviewers on these technical topics. We also have a group of Followees who vote independently on the Governance and the SNS & Neurons’ Fund topics. We strive to be a credible and reliable Followee option that votes on every proposal and every proposal topic in the NNS. We also support decentralisation of SNS projects such as WaterNeuron, KongSwap, and Alice with a known neuron and credible Followees.
Learn more about CodeGov and its mission at codegov.org.