Proposal 134185
Vote: Adopt
Reason: Build is successful, hashes match, commits match descriptions and the reasoning behind the changes is sound.
I’ve reviewed commits selectively, focusing on Consensus and Interface changes. Among other things these include changes relating to the QUIC transport layer and further steps towards the upcoming VetKeys implementation.
Review
Features:
[675edd43b]
Reduces the acceptable gap between the finalised height and the certified height from 2 blocks to 1 block, following on from an earlier change from 3 blocks to 2.
[f96077d44]
Version change for several packages, change of source crate for several elements and related code changes as outlined in the commit notes.
[ed45bab1d]
Implements lazy initialisation of storage for files backing PageMaps, such that the storage structure is only initiated once it’s needed. Changes include addition of lazy_load and other new methods to Storage in rs/replicated_state/src/page_map/storage.rs and use of these in rs/replicated_state/src/page_map.rs.
[4e83be165]
Changes to IC-OS configuration tool including replacing some GuestOSSettings and ICOSSettings fields with booleans, addition of config_version fields, added file generate_testnet_config.rs and new commands GenerateGuestosConfig and GenerateTestnetConfig.
Bugfixes:
[bda7e8c90]
Code change to QUIC transport request handler such that recv_stream is dropped from scope before send_stream is accessed. Adds ‘{:?}’ to log statements in order to display detailed error messages.
[e500f911f]
Renames SendStreamDropGuard to ResetStreamOnDrop and moves it from quic_transport/src/connection_handle.rs to quic_transport/src/lib.rs. Changes to error reporting.
[c578a156b]
Removes peer_id field from ConnectionHandle.
[e5faeaaf7]
Several changes to SetupOS, mainly concerning tests, as explained in detail in the commit notes.
Chores:
[896cafb19]
Removes fields pseudo_random_id and pre_signature_id from and adds field callback_id to RequestId, and changes to other code accordingly. The intention is to enable RequestId to be re-used in requests in the VetKeys implementation, as explained in the commit notes.
[8b01b687e] [b1c0f8ccc]
Version updates for various packages.
[073f73166]
Removal of TODO comments.
[2d68a2e31]
Addition and use of new error types in relation to the QUIC transport layer.
[3f1716678]
Readability changes to QUIC transport code, including changes to some field names, removal of conn_id_counter field from ConnectionManager and addition of metrics field to run_stream_acceptor.
[4bd76d3bc]
Changes to QUIC transport code including expanded documentation, field changes, and changes to error handling within request_handler.rs such that an unspecified http method will return None rather than an error.
[3c3d9cd36]
Moves MasterPublicKeyId and associated enums from registry/crypto/v1 to types/v1 in order to prevent planned future changes from creating a circular dependency.
Tests:
[ae957017c]
Adds get_id function to impl HasId<NiDkgTag> for NiDkgTranscript in preparation for planned future changes, as explained in commit notes.
[3ad26ca77 Interface(IDX): inline more NNS system-tests (#2574)]
Removal of various tests from rs/tests/src/ledger_tests/ and rs/tests/src/nns_tests/ into rs/tests/nns/.
Proposal 134186
Vote: Adopt
Reason: Build is successful. Hashes match. The proposal consists of a single commit (previously seen) which enables the hashes-in-blocks feature.
Proposal 134187
Vote: Adopt
Reason: Build is successful. Hashes match. The proposal consists of a single commit (previously seen) which upgrades Linux kernel version to 6.11 and installs the kernel.
Proposal 134188
Vote: Adopt
Reason: Build is successful. Hashes match. The proposal consists of a single commit which reverts a previous commit upgrading GuestOS to Ubuntu 24.04.