Proposal 136987 | Tim - CodeGov
Vote: Adopt
Reason: Build is successful, hashes match, commits match descriptions and the reasoning behind the changes is sound. Commits are reviewed below.
[63c402b5d4]
Removes schedule_unstake_maturity_of_dissolved_neurons and schedule_neuron_data_validation (relying on ic_cdk_timers) from scheduling in governance/canister/canister.rs, and replaces these with equivalent tasks in governance/src/timer_tasks/mod.rs, making use of the PeriodicSyncTask trait (explained here) from ic_nervous_system_timer_task.
[4e04664edc]
Removes the now redundant is_disburse_maturity_enabled flag along with related structures and tests.
[243be670a2]
Removes type Neuron (used as pb::v1::neuron) from the governance protobuf, replacing its use throughout the code with ic_nns_governance_api::neuron, and associated code changes as outlined in the commit notes.
[8b4da93fc6]
Adapts Destination::into_account_identifier_proto in the maturity disbursement code so that it gives a 32-byte account identifier, equivalent to the “ICP address”, instead of the previous 28-byte identifier.
[3671acb49d]
Upgrades Rust version from 1.85.1 to 1.86.0 again, as the issue causing test failures the last time this was attempted has now been identified and a workaround put in place (and included within the commit).
[0939e4e4d8]
Adapts CanisterManager::validate_specified_id method to require specified_id (of a canister) not to belong to the canister allocation ranges, the concept of which is explained here. The intention is for this validation to be used for canister creation in test environments.
[2dd93c8aeb]
Un-nests type Followees from the Neuron definition, as per commit notes.
[c36e3971df]
Removes neurons field from type Governance (used as GovernanceProto in most of the code) as this field is no longer in use.
[31872377e4]
Removes prop_assert_changes and assert_changes macros along with the associated test_single_neuron_proposal_new test. Also removes prop_assert_changes! from do_test_merge_neurons. These performed an assertion on the entire NNS Governance state, which has now become unwieldy.
[b31d3151e7]
Adds flag flaky = True for all tests within the governance_integration_test suite so that they will show up as such on dashboards, as these tests have been timing out frequently.
[b3efb00f64]
Updates changelog files for various system canisters.
Proposal 136988
Vote: Adopt
Reason: Build is successful, hashes match, commits match descriptions and the reasoning behind the changes is sound. Commits are reviewed below.
[83f3b8b30f]
Introduces several benchmark tests and integrates canbench into the registry canister module, as per description.
[5f8a1b5d20]
Sets the IS_CHUNKIFYING_LARGE_VALUES_ENABLED flag to true in order to allow chunking of large (> 2 MiB) messages. This is a breaking change as explained here.
[cc5c9c98e2]
Adds new function mutations_for_canister_ranges which is then used in Registry methods for modifying the routing table (adding or removing a subnet, migrating canisters to a subnet or remapping a specified canister ID range to another subnet) to produce a vector of RegistryMutations. The intention of this and related changes is to allow the routing table to be broken up into canister_ranges_* records rather than just stored as a single record.
[b3efb00f64]
Reviewed above.
About CodeGov
CodeGov has a team of developers who review and vote independently on the following proposal topics: IC-OS Version Election, Protocol Canister Management, Subnet Management, API Boundary Node Management, Node Admin, and Participant Management. The CodeGov NNS known neuron is configured to follow our reviewers on these technical topics. We also have a group of Followees who vote independently on the Governance and the SNS & Neurons’ Fund topics. We strive to be a credible and reliable Followee option that votes on every proposal and every proposal topic in the NNS. We also support decentralisation of SNS projects such as WaterNeuron, KongSwap, and Alice with a known neuron and credible Followees.
Learn more about CodeGov and its mission at codegov.org.