Thanks @timk11, I’m only asking because I care. I can tell that you do to, and I appreciate your response.
Do you think this is the sort of bug that could be detected this way?
Do you think you should be doing anything differently?
Regardless of CodeGov’s or DFINITY’s stance, CO.DELTA are aiming to raise the bar in this respect.
The IC deserves reviewers who go above and beyond. In any case, testing the code you’re reviewing is normal code review practice. Unlike the IC OS, which has limitations in terms of the practical test surface (though PocketIC can be useful here), I don’t see any reasonable excuse for not running Protocol Canister Management changes locally as part of a typical review, particularly on canisters such as NNS Governance.