# Modify nns front code

**URL:** <https://forum.dfinity.org/t/modify-nns-front-code/18560>\
**Category:** Developers\
**Tags:** nns, Bug\
**Created:** [February 18, 2023, 9:48am UTC](https://forum.dfinity.org/t/modify-nns-front-code/18560 "2023-02-18T09:48:30Z")\
**Posts on this page:** 6\
**Page:** 1

<div class="post-metadata">

**Author:** ![NeutronStarPRO](https://sea1.discourse-cdn.com/flex023/user_avatar/forum.dfinity.org/neutronstarpro/32/13617_2.png) [@NeutronStarPRO](https://forum.dfinity.org/u/NeutronStarPRO)\
**Post date:** [February 18, 2023, 9:48am UTC](https://forum.dfinity.org/t/modify-nns-front-code/18560/1 "2023-02-18T09:48:30Z")

</div>

![image](https://us1.discourse-cdn.com/flex023/uploads/dfn/original/2X/e/e85abcf55fe966907a1c171932d3c7ccdade4906.png)

 ![1676713687243](https://us1.discourse-cdn.com/flex023/uploads/dfn/original/2X/b/be8b5d4d29598e90ed2ade72103d42ba68abaa48.png)

---

<div class="post-metadata">

**Author:** ![peterparker](https://avatars.discourse-cdn.com/v4/letter/p/b9bd4f/32.png) [@peterparker](https://forum.dfinity.org/u/peterparker)\
**Post date:** [February 18, 2023, 10:59am UTC](https://forum.dfinity.org/t/modify-nns-front-code/18560/2 "2023-02-18T10:59:47Z")

</div>

Nice catch. 👍 Are you using Firefox?

I can reproduce it with Firefox only, Safari and Chrome are fine. Looks like the height is not properly computed once the node attached to the DOM.

---

<div class="post-metadata">

**Author:** ![peterparker](https://avatars.discourse-cdn.com/v4/letter/p/b9bd4f/32.png) [@peterparker](https://forum.dfinity.org/u/peterparker)\
**Post date:** [February 18, 2023, 11:17am UTC](https://forum.dfinity.org/t/modify-nns-front-code/18560/3 "2023-02-18T11:17:23Z")

</div>

Fix on the way for next version. Thanks again for the report.

> <https://github.com/dfinity/gix-components/pull/158>
>
> \# Motivation
> 
> A user noticed and reported on the \[forum\](https://forum.dfinity….org/t/modify-nns-front-code/18560) an issue with the \`Collapsible\` component which did not computed the expandable height correctly. I was able to reproduce it in Firefox only.
> 
> \# Changes
> 
> \- fix height computation of the \`Collapsible\` element by using primarly the \`getBoundingClientRect\` API which according test seems more accurate on Firefox and compatible with Chrome, Safari and iOS
> 
> \# Screenshots
> 
> Bug
> 
> !\[bug\](https://user-images.githubusercontent.com/16886711/219857326-910339ab-a1e6-41dd-9cc4-eb73be58c829.gif)
> 
> Fix
> 
> !\[fix\](https://user-images.githubusercontent.com/16886711/219857333-cafd87ca-387e-49b5-8479-119110ca8e05.gif)

---

<div class="post-metadata">

**Author:** ![NeutronStarPRO](https://sea1.discourse-cdn.com/flex023/user_avatar/forum.dfinity.org/neutronstarpro/32/13617_2.png) [@NeutronStarPRO](https://forum.dfinity.org/u/NeutronStarPRO)\
**Post date:** [February 18, 2023, 11:44am UTC](https://forum.dfinity.org/t/modify-nns-front-code/18560/4 "2023-02-18T11:44:20Z")

</div>

I use chrome and laptop screen with 125% zoom in win11.  
The resolution is 1920x1080.

If I change the screen to 100% size, it is normal, but it is too small for the laptop screen. I usually use (also recommended by the system) 125%.

 ![image](https://us1.discourse-cdn.com/flex023/uploads/dfn/original/2X/4/4fab7d3ec74469c63e81aef9def2691c4a35ccf0.jpeg)  
 ![image](https://us1.discourse-cdn.com/flex023/uploads/dfn/original/2X/0/0039ce51c2bbe3a44d16f0fb3ae26b3108a01a43.jpeg)

I hope my information is useful

---

<div class="post-metadata">

**Author:** ![peterparker](https://avatars.discourse-cdn.com/v4/letter/p/b9bd4f/32.png) [@peterparker](https://forum.dfinity.org/u/peterparker)\
**Post date:** [February 18, 2023, 11:47am UTC](https://forum.dfinity.org/t/modify-nns-front-code/18560/5 "2023-02-18T11:47:52Z")

</div>

Ah cool to know, thanks for the feedback.

I just tested locally (I’m on Mac) the 125% zoom with Chrome and the fix. Result was ok, therefore I would say the fix does definitely looks good.

Please let me know once next version proposal is executed if it would not be the case.

 ![Capture d’écran 2023-02-18 à 12.45.55](https://us1.discourse-cdn.com/flex023/uploads/dfn/original/2X/7/70e01c8717589347de015b47ebad75cd4d54bf8c.jpeg)

---

<div class="post-metadata">

**Author:** ![NeutronStarPRO](https://sea1.discourse-cdn.com/flex023/user_avatar/forum.dfinity.org/neutronstarpro/32/13617_2.png) [@NeutronStarPRO](https://forum.dfinity.org/u/NeutronStarPRO)\
**Post date:** [February 18, 2023, 11:48am UTC](https://forum.dfinity.org/t/modify-nns-front-code/18560/6 "2023-02-18T11:48:04Z")

</div>

![1676720851006](https://us1.discourse-cdn.com/flex023/uploads/dfn/original/2X/6/679330f04c310ab9a702009b79bd9abd117b03a2.png)  
 ![1676721037669](https://us1.discourse-cdn.com/flex023/uploads/dfn/original/2X/7/75d4495a9d5778d550a11332f2a5b8ac9d985686.png)
